Update table and row styles for mobile search pages#87742
Draft
Krishna2323 wants to merge 14 commits intoExpensify:mainfrom
Draft
Update table and row styles for mobile search pages#87742Krishna2323 wants to merge 14 commits intoExpensify:mainfrom
Krishna2323 wants to merge 14 commits intoExpensify:mainfrom
Conversation
…, restructure 2-line content, remove card spacing Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…w layout Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…increase violation margin Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Contributor
|
Looks like we have some conflicts... |
Contributor
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
Contributor
Contributor
Contributor
|
We need to update the skeleton rows too: How about something like this? |
Contributor
Contributor
Contributor
Contributor
Author
|
@shawnborton sorry for not being super clear here #87460 (comment) 😅. I have only worked on reports and expenses tab yesterday. Will continue working on other updates today. |
Contributor
|
Sounds good, I'm just so excited! |
…trip Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…rinking Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…n narrow layout Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…tar and status badge Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.











Explanation of Change
Fixed Issues
$ #87460
PROPOSAL:
Tests
Verify that no errors appear in the JS console
Offline tests
QA Steps
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari