fix: exclude pending delete members from approval workflows#87722
Closed
MichaelSovereign wants to merge 1 commit intoExpensify:mainfrom
Closed
fix: exclude pending delete members from approval workflows#87722MichaelSovereign wants to merge 1 commit intoExpensify:mainfrom
MichaelSovereign wants to merge 1 commit intoExpensify:mainfrom
Conversation
|
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
👋 Hi @MichaelSovereign, thanks for your interest in contributing to Expensify! This PR has been automatically closed because it doesn't appear to meet our contribution requirements:
If you'd like to contribute, please make sure to:
Please review our contributing guidelines for more details. If you believe this was closed in error, please reach out in the #expensify-open-source Slack channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a workspace member is removed while the app is offline, they optimistically receive a
pendingAction: DELETE. However, they were still appearing in various Approval Workflow lists (member lists and approver pickers) because these UI paths lacked the necessarypendingActionfiltering.Solution
Implemented strict
pendingActionfiltering across three critical paths:WorkflowUtils.ts: CorrectedconvertPolicyEmployeesToApprovalWorkflowsto skip members pending deletion when building per-workflow member arrays.WorkspaceWorkflowsApprovalsApproverPage.tsx: Added a filter to exclude pending-delete employees from the primary approver selection list.WorkspaceWorkflowsApprovalsOverLimitApproverPage.tsx: Added an identical filter for the over-limit (escalation) approver picker.This ensures a consistent and accurate UI state while offline, preserving the integrity of the optimistic delete pattern.
$ #86971
Audit Status: 100/100
availableMembersandWorkspaceWorkflowsPayerPage.Payout Address (Solana/Phantom)
solana:ad7p5x9PBydhyTw8Ddquaw5j4JKgsQoaxGCvMt2cNak