Skip to content

feat: user pill workflow attendees#87705

Open
TaduJR wants to merge 6 commits intoExpensify:mainfrom
TaduJR:feat-user-pill-workflow-attendees
Open

feat: user pill workflow attendees#87705
TaduJR wants to merge 6 commits intoExpensify:mainfrom
TaduJR:feat-user-pill-workflow-attendees

Conversation

@TaduJR
Copy link
Copy Markdown
Contributor

@TaduJR TaduJR commented Apr 11, 2026

Explanation of Change

Replaces plain comma-separated text with avatar + name pill components in approval workflow rows and expense attendee lists.

  • New UserPill and UserPills reusable components with count-based overflow (default 9 visible, "+X more" with tooltip on web)
  • ApprovalWorkflowSection: members rendered as pills via titleComponent (default "Everyone" workflow stays plain text), approver rows show actual user avatars instead of generic icons
  • MoneyRequestView: attendees rendered as pills via titleComponent, removed shouldRenderAsHTML
  • plusMore translation added across all 10 languages

Fixed Issues

$ #84985
PROPOSAL: #84985 (comment)

Tests

Approval Workflow Pills

  1. Navigate to a workspace (must be Control plan) > Workflows
  2. Enable Approvals toggle if not already enabled
  3. Click "Add approval workflow", add 10+ members and an approver, save
  4. Verify members are displayed as avatar + name pills (not plain comma-separated text)
  5. Verify the default workflow still shows "Everyone" as plain text
  6. Verify each approver row shows the approver's actual avatar next to their name
  7. Verify a "+X more" indicator appears when members exceed 9
  8. (Web only) Hover over "+X more" and verify a tooltip shows the hidden member names
  9. Click the workflow section and verify it still navigates to the edit RHP
  10. If an approver has an approval limit configured, verify the limit description still appears below the approver pill

Expense Attendee Pills
11. Create an expense in a Corporate workspace with attendee tracking enabled
12. Add 10+ attendees to the expense
13. Submit the expense and view the expense details
14. Verify attendees are displayed as avatar + name pills
15. Verify "+X more" appears when attendees exceed 9
16. (Web only) Hover over "+X more" and verify a tooltip shows hidden attendee names

  • Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari Screenshot 2026-04-11 at 4 03 59 in the afternoon Screenshot 2026-04-11 at 4 27 06 in the afternoon

@TaduJR TaduJR requested review from a team as code owners April 11, 2026 13:28
@melvin-bot melvin-bot bot requested a review from JmillsExpensify April 11, 2026 13:28
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 11, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot melvin-bot bot requested review from nyomanjyotisa and removed request for a team and JmillsExpensify April 11, 2026 13:28
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 11, 2026

@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from a team and flaviadefaria and removed request for a team April 11, 2026 13:28
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/UserPill.tsx 100.00% <100.00%> (ø)
src/components/UserPills.tsx 100.00% <100.00%> (ø)
...ace/workflows/approvals/ApprovalWorkflowEditor.tsx 86.95% <100.00%> (+3.23%) ⬆️
src/styles/index.ts 48.20% <ø> (ø)
.../components/MoneyRequestConfirmationListFooter.tsx 52.18% <71.42%> (+0.19%) ⬆️
...s/WorkspaceWorkflowsApprovalsApprovalLimitPage.tsx 0.00% <0.00%> (ø)
src/components/ApprovalWorkflowSection.tsx 0.00% <0.00%> (ø)
...c/components/ReportActionItem/MoneyRequestView.tsx 64.57% <0.00%> (-0.89%) ⬇️
... and 16 files with indirect coverage changes

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f6fc1d080

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant