Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-ADDRESSABLE-15924312
|
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
All checks on this PR are currently passing (or skipping/pending). There are no failing checks to fix. The only non-complete check is |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf329acc48
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| benchmark | ||
| bigdecimal | ||
| cocoapods (= 1.16.2) | ||
| fastlane (~> 2, >= 2.229.0) | ||
| fastlane-plugin-aws_s3 | ||
| fastlane-plugin-firebase_app_distribution | ||
| fastlane (~> 2, >= 2.229.1) |
There was a problem hiding this comment.
Re-add fastlane plugins to Gemfile.lock dependencies
Gemfile still pulls in fastlane/Pluginfile via eval_gemfile (Gemfile:14-15), and that plugin file still declares fastlane-plugin-aws_s3 and fastlane-plugin-firebase_app_distribution (fastlane/Pluginfile:5-6), but this lockfile dependency block no longer locks either gem. In environments that run bundle exec fastlane (for example .github/workflows/deploy.yml:154 and :387), this makes the lockfile out of sync with declared dependencies, which causes Bundler to stop before lanes execute.
Useful? React with 👍 / 👎.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari