[No QA]: Move report workflow functions to IOU/ReportWorkflow.ts#87692
Draft
DylanDylann wants to merge 2 commits intoExpensify:mainfrom
Draft
[No QA]: Move report workflow functions to IOU/ReportWorkflow.ts#87692DylanDylann wants to merge 2 commits intoExpensify:mainfrom
DylanDylann wants to merge 2 commits intoExpensify:mainfrom
Conversation
Move 13 report workflow functions from IOU/index.ts into a dedicated ReportWorkflow.ts module (Expensify#72804): Validators: canApproveIOU, canUnapproveIOU, canIOUBePaid, canCancelPayment, canSubmitReport, getIOUReportActionWithBadge, getReportOriginalCreationTimestamp Workflow: approveMoneyRequest, determineIouReportID, reopenReport, retractReport, unapproveExpenseReport, submitReport Also move types: SubmitReportFunctionParams, ApproveMoneyRequestFunctionParams. Update ~17 consumer file imports. Move ~12 test blocks to tests/actions/IOUTest/ReportWorkflowTest.ts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove unused Navigation/ROUTES imports from ReportWorkflow.ts - Fix broken destructuring in approveMoneyRequest and submitReport - Remove unused billing restriction params - Remove ~16 unused imports from index.ts - Remove ~10 unused imports from IOUTest.ts - Remove unused vars/imports from ReportWorkflowTest.ts - Fix RORY_ACCOUNT_ID use-before-define Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Extract 13 report workflow functions from
src/libs/actions/IOU/index.tsinto a newsrc/libs/actions/IOU/ReportWorkflow.tsmodule:Validators:
canApproveIOU,canUnapproveIOU,canIOUBePaid,canCancelPayment,canSubmitReport,getIOUReportActionWithBadge,getReportOriginalCreationTimestampWorkflow:
approveMoneyRequest,determineIouReportID,reopenReport,retractReport,unapproveExpenseReport,submitReportAlso move types:
SubmitReportFunctionParams,ApproveMoneyRequestFunctionParams.Move corresponding tests to
tests/actions/IOUTest/ReportWorkflowTest.ts. Update ~17 consumer file imports accordingly.Fixed Issues
$ #72804
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.