Draft
Conversation
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 8c943f77..421523b0 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2496,6 +2496,8 @@ ${amount} für ${merchant} – ${date}`,
frozenByAdminNeedsUnfreezePrefix: 'Diese Karte wurde von ',
frozenByAdminNeedsUnfreezeSuffix: ' gesperrt. Bitte kontaktiere einen Admin, um sie zu entsperren.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Diese Karte wurde von ${person} gesperrt. Bitte kontaktiere einen Admin, um sie zu entsperren.`,
+ spendRules: 'Ausgaberegeln',
+ editSpendRules: 'Ausgaberegeln bearbeiten',
},
workflowsPage: {
workflowTitle: 'Ausgaben',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 9cf7d500..12d05fc7 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2503,6 +2503,8 @@ ${amount} pour ${merchant} - ${date}`,
frozenByAdminNeedsUnfreezePrefix: 'Cette carte a été gelée par ',
frozenByAdminNeedsUnfreezeSuffix: '. Veuillez contacter un administrateur pour la dégeler.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Cette carte a été gelée par ${person}. Veuillez contacter un administrateur pour la dégeler.`,
+ spendRules: 'Règles de dépense',
+ editSpendRules: 'Modifier les règles de dépense',
},
workflowsPage: {
workflowTitle: 'Dépense',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 76404440..4db527b2 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2492,6 +2492,8 @@ ${amount} per ${merchant} - ${date}`,
frozenByAdminNeedsUnfreezePrefix: 'Questa carta è stata bloccata da ',
frozenByAdminNeedsUnfreezeSuffix: '. Contatta un amministratore per sbloccarla.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Questa carta è stata bloccata da ${person}. Contatta un amministratore per sbloccarla.`,
+ spendRules: 'Regole di spesa',
+ editSpendRules: 'Modifica le regole di spesa',
},
workflowsPage: {
workflowTitle: 'Spesa',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 273c2fdb..bf491074 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2467,6 +2467,8 @@ ${date} の ${merchant} への ${amount}`,
frozenByAdminNeedsUnfreezePrefix: 'このカードは',
frozenByAdminNeedsUnfreezeSuffix: 'によって一時停止されました。解除するには管理者に連絡してください。',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `このカードは${person}によって一時停止されました。解除するには管理者に連絡してください。`,
+ spendRules: '支出ルール',
+ editSpendRules: '支出ルールを編集',
},
workflowsPage: {
workflowTitle: '支出',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 0195d134..0ea07ec3 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2490,6 +2490,8 @@ ${amount} voor ${merchant} - ${date}`,
frozenByAdminNeedsUnfreezePrefix: 'Deze kaart is bevroren door ',
frozenByAdminNeedsUnfreezeSuffix: '. Neem contact op met een beheerder om deze te deblokkeren.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Deze kaart is bevroren door ${person}. Neem contact op met een beheerder om deze te deblokkeren.`,
+ spendRules: 'Uitgavenregels',
+ editSpendRules: 'Uitgavenregels bewerken',
},
workflowsPage: {
workflowTitle: 'Uitgaven',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 6af69911..77fe3d4f 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2485,6 +2485,8 @@ ${amount} dla ${merchant} - ${date}`,
frozenByAdminNeedsUnfreezePrefix: 'Ta karta została zamrożona przez ',
frozenByAdminNeedsUnfreezeSuffix: '. Skontaktuj się z administratorem, aby ją odmrozić.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Ta karta została zamrożona przez ${person}. Skontaktuj się z administratorem, aby ją odmrozić.`,
+ spendRules: 'Zasady wydatków',
+ editSpendRules: 'Edytuj reguły wydatków',
},
workflowsPage: {
workflowTitle: 'Wydatki',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index b875cedd..67117926 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2483,6 +2483,8 @@ ${amount} para ${merchant} - ${date}`,
frozenByAdminNeedsUnfreezePrefix: 'Este cartão foi bloqueado por ',
frozenByAdminNeedsUnfreezeSuffix: '. Entre em contato com um administrador para desbloqueá-lo.',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `Este cartão foi bloqueado por ${person}. Entre em contato com um administrador para desbloqueá-lo.`,
+ spendRules: 'Regras de gasto',
+ editSpendRules: 'Editar regras de gasto',
},
workflowsPage: {
workflowTitle: 'Gastos',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 10a8e806..bea33bec 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2414,6 +2414,8 @@ ${amount}，商户：${merchant} - 日期：${date}`,
frozenByAdminNeedsUnfreezePrefix: '此卡已被',
frozenByAdminNeedsUnfreezeSuffix: '冻结。请联系管理员解冻。',
frozenByAdminNeedsUnfreeze: ({person}: {person: string}) => `此卡已被${person}冻结。请联系管理员解冻。`,
+ spendRules: '支出规则',
+ editSpendRules: '编辑支出规则',
},
workflowsPage: {
workflowTitle: '支出',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #86525
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari