fix: Re-apply screen reader disabled button announcement with crash fix#87670
Draft
fix: Re-apply screen reader disabled button announcement with crash fix#87670
Conversation
Re-applies the changes from the reverted PR that fixed screen readers not announcing disabled state of buttons. Additionally coerces non-boolean disabled values to booleans in TimezoneInitialPage, TimezoneSelectPage, and SamlLoginSectionContent to prevent the native crash that caused the previous revert. Co-authored-by: Rory Abraham <roryabraham@users.noreply.github.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
Link to discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Re-applies the screen reader fix from the reverted PR (#86888) that makes screen readers properly announce disabled button state, plus fixes the regression that caused the revert.
Screen reader fix (re-applied from #86888):
BaseGenericPressable.tsx: Changeddisabled={fullDisabled}→disabled={fullDisabled || undefined}so React Native's Pressable doesn't overwriteaccessibilityState.disabledwhen the button is not fully disabledindex.tsx(web): Added auseLayoutEffectto imperatively setaria-disabledon the DOM element, since react-native-web's Pressable always derivesaria-disabledfrom its owndisabledpropCrash fix (prevents deploy blocker #87629):
TimezoneInitialPage.tsx: Changeddisabled={timezone.automatic}→disabled={!!timezone.automatic}— the backend may returntimezone.automaticas a string (e.g."true"), which crashes native when passed toaccessibilityState.disabled(expects boolean)TimezoneSelectPage.tsx: Same coercion forisDisabledpropSamlLoginSectionContent.tsx: Same coercion fordomainSettings?.twoFactorAuthRequiredFixed Issues
$ #76908
PROPOSAL: #76908 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari