fix: prevent Move expense from appearing on forwarded reports

[mavrickdeveloper]

Explanation of Change

• This PR fixes the issue where the "Move expense" option incorrectly appears on forwarded reports when the FORWARDED action is missing from local Onyx data (e.g. in copilot/delegate sessions).

Root Cause:

• isReportOutstanding() relies on hasForwardedAction() to detect forwarded reports, but this check only inspects locally available REPORT_ACTIONS.
• In copilot/delegate sessions, the FORWARDED action may not be present in local Onyx data, causing the report to appear outstanding when it has actually been forwarded to a higher-level approver.
• This results in "Move expense" being shown on reports where it should be hidden.

Solution:

• Add a hasForwardedByManagerChange() fallback in isReportOutstanding() that detects forwarded reports by comparing getSubmitToAccountID() against managerID for processing reports.
• Include a DEW (Dynamic External Workflow) guard via hasPendingDEWApprove() / hasPendingDEWSubmit() to skip the fallback when a DEW operation is pending, preventing false positives.
• The fallback only triggers for processing reports (isProcessingReport()), so open/draft/approved/paid reports are unaffected.

Known limitation:

• When approver personal details are missing from PERSONAL_DETAILS_LIST (partial Onyx hydration), getSubmitToAccountID() may return a synthetic ID that doesn't match managerID, causing a conservative false positive (Move hidden when it should be visible). The failure mode is conservative , it over-hides rather than over-shows.

Fixed Issues

$ #79602
PROPOSAL: #79602 (comment)

Tests

Prerequisites:

• Two user accounts: User A (submitter), User B (approver/manager)
• A workspace with a multi-level approval chain (e.g. User A → User B → User C)
• User B is logged in

Primary Tests (Fix Validation):

1. As User A, create and submit an expense report on the workspace
2. As User B (first approver), approve the report ,it is now forwarded to User C
3. As User B, navigate to Search > Expenses (type: expense, status: all)
4. Select the forwarded expense via checkbox
5. Open bulk actions menu ("1 selected" button)
6. Verify "Move expense" is NOT shown in the menu

Non-Regression Tests:

7. As User B, find an outstanding expense report (submitted by User A, not yet approved)

8. Select the expense via checkbox in Search > Expenses

9. Open bulk actions menu

10. Verify "Move expense" IS shown in the menu

11. Select a paid expense via checkbox

12. Open bulk actions menu

13. Verify "Move expense" is NOT shown

14. Select a held expense via checkbox

15. Open bulk actions menu

16. Verify "Move expense" is NOT shown

Copilot/Delegate Session Test:

17. Log in as a copilot of User A
18. Navigate to a forwarded expense report where FORWARDED action may not be in local Onyx
19. Select the expense and open bulk actions
20. Verify "Move expense" is NOT shown

• Verify that no errors appear in the JS console

Offline tests

N/A - The fix operates on locally cached Onyx data (REPORT_ACTIONS, REPORT_METADATA, PERSONAL_DETAILS_LIST). Move expense eligibility is determined client-side from already-synced state.

QA Steps

Same as Primary Tests (steps 1–6) and Non-Regression Tests (steps 7–16) above.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • Windows: Chrome
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Web: Move expense hidden on forwarded report

Web: Move expense visible on outstanding (non-forwarded) report

Web: Move expense hidden on paid report

Web: Move expense hidden on held report

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	75.24% <91.66%> (+0.03%)	⬆️
... and 20 files with indirect coverage changes