Improve OD ND time #78773

elirangoshen · 2026-01-02T11:13:43Z

Explanation of Change

Fixed Issues

$#77172
PROPOSAL: this PR Improves time takes to get from oldDot to newDot via Try New Expensify button.

It does it by executing prepareHybridAppAfterTransitionToNewDot in parallel with other async actions and by using Onyx.set instead of Onyx.merge in side prepareHybridAppAfterTransitionToNewDot. (the merge is actually replacing the whole value of the key)

It improves in our big perf account in around 1.5-2 seconds the time, via local inspections and sentry.

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
try is from your main branch / build that not including this change

Go to old dot (via button "switch to expensify classic" from troubleshoot menu)
Open the side menu and click on "Try New Expensify" button
After it switched to new dot, locate that span in sentry ManualOdNdTransition and look for the duration, you can use for example this link

Now do the same process again with the build that includes this pr, and compare between the durations.

Expected Result:

The span duration need to be faster

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-01-02T11:13:49Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-02T11:24:52Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/HybridApp/index.ts	`0.00% <0.00%> (ø)`
src/libs/actions/Session/index.ts	`42.92% <0.00%> (ø)`
... and 11 files with indirect coverage changes

sosek108 · 2026-01-02T14:11:29Z

@elirangoshen

Are you sure this is No QA? I'd rather have QA to test if nothing broke. Add test steps also, please

sosek108 · 2026-01-02T14:12:11Z

NAB: Also this is not Sentry related change, so I'd remove [Sentry] from title

abzokhattab · 2026-01-02T14:16:19Z

reviewing..

mountiny

Looks good but I would definitely encourage adding test steps to this in case there are some race conditions or some other issues

elirangoshen · 2026-01-02T14:22:43Z

Looks good but I would definitely encourage adding test steps to this in case there are some race conditions or some other issues

ok I added QA steps

github-actions · 2026-01-02T14:25:04Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-02T14:57:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #78773.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ed0b44488221c3c70ffd30247e83c9068cc04747/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-70cf12599dbc7b68596014278df5291939d6ea1f/index.html

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://78773.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

elirangoshen · 2026-01-02T15:11:29Z

@elirangoshen

Are you sure this is No QA? I'd rather have QA to test if nothing broke. Add test steps also, please

yes its added

elirangoshen · 2026-01-02T15:12:21Z

NAB: Also this is not Sentry related change, so I'd remove [Sentry] from title

sure fixed

abzokhattab · 2026-01-02T15:25:24Z

src/libs/actions/HybridApp/index.ts

 function prepareHybridAppAfterTransitionToNewDot(hybridApp: HybridApp) {
    if (hybridApp?.useNewDotSignInPage) {
-        return Onyx.merge(ONYXKEYS.HYBRID_APP, {
+        return Onyx.set(ONYXKEYS.HYBRID_APP, {


by using Onyx.set instead of Onyx.merge in side prepareHybridAppAfterTransitionToNewDot. (the merge is actually replacing the whole value of the key)

Nice work on the parallelization .. the perf win there makes sense. One question about switching Onyx.merge → Onyx.set for ONYXKEYS.HYBRID_APP: merge doesn’t generally replace the whole object. it preserves existing fields not present in the incoming payload. With set, we overwrite the entire key and could drop any HYBRID_APP fields that were previously set on the NewDot side but aren’t included in hybridAppSettings.hybridApp. Is the intent here to always fully override HYBRID_APP during the OD→ND transition? i am asking because performance wise merge and set should be nearly the same in this case .. so i wouldnt probably change it .. but would love to hear your thoughts

This is my concern too with this change

abzokhattab · 2026-01-02T15:50:33Z

Through my testing, I’m seeing a good improvement in duration in my case as well.

I clicked the button three times with the new build, and it gives a better result than the two older clicks with an older build.

Screen.Recording.2026-01-02.at.16.47.37.mov

abzokhattab · 2026-01-02T16:05:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-02.at.16.47.37.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

abzokhattab

overall it looks good to me ... i just left one comment here .. let me know what u think https://github.com/Expensify/App/pull/78773/changes#r2657903072

improve time

6fb1e68

elirangoshen requested review from a team as code owners January 2, 2026 11:13

melvin-bot bot assigned elirangoshen Jan 2, 2026

melvin-bot bot requested review from thesahindia and removed request for a team January 2, 2026 11:13

melvin-bot bot requested review from JmillsExpensify, flaviadefaria, heyjennahay, joekaufmanexpensify and trjExpensify and removed request for a team January 2, 2026 11:13

retain original order of event

a85d3fb

elirangoshen mentioned this pull request Jan 2, 2026

Improve OD → ND Transition Performance #77172

Open

mountiny requested review from mountiny and removed request for JmillsExpensify, flaviadefaria, heyjennahay, joekaufmanexpensify, thesahindia and trjExpensify January 2, 2026 14:11

mountiny requested a review from abzokhattab January 2, 2026 14:15

mountiny reviewed Jan 2, 2026

View reviewed changes

mountiny changed the title ~~[No QA] [Sentry] Improve OD ND time~~ [Sentry] Improve OD ND time Jan 2, 2026

elirangoshen changed the title ~~[Sentry] Improve OD ND time~~ Improve OD ND time Jan 2, 2026

abzokhattab reviewed Jan 2, 2026

View reviewed changes

abzokhattab approved these changes Jan 2, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny January 2, 2026 16:06

Improve OD ND time #78773

Are you sure you want to change the base?

Improve OD ND time #78773

Conversation

elirangoshen commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 2, 2026

Uh oh!

codecov bot commented Jan 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sosek108 commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sosek108 commented Jan 2, 2026

Uh oh!

abzokhattab commented Jan 2, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

elirangoshen commented Jan 2, 2026

Uh oh!

github-actions bot commented Jan 2, 2026

Uh oh!

github-actions bot commented Jan 2, 2026

Uh oh!

elirangoshen commented Jan 2, 2026

Uh oh!

elirangoshen commented Jan 2, 2026

Uh oh!

abzokhattab Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

abzokhattab commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abzokhattab commented Jan 2, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

elirangoshen commented Jan 2, 2026 •

edited

Loading

codecov bot commented Jan 2, 2026 •

edited by github-actions bot

Loading

sosek108 commented Jan 2, 2026 •

edited

Loading

abzokhattab Jan 2, 2026 •

edited

Loading

abzokhattab commented Jan 2, 2026 •

edited

Loading