-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: Card column changes to card number and reverts to card name after editing expense #78769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r editing expense
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| isAmountColumnWide, | ||
| isTaxAmountColumnWide, | ||
| isLargeScreenWidth, | ||
| hash, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed now but wasn't needed earlier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShridharGoel I added by the suggestion from lint. Look like we missed it before.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-02.at.8.12.10.PM.moviOS: HybridAppMacOS: Chrome / SafariScreen.Recording.2026-01-02.at.8.08.43.PM.mov |


Explanation of Change
Fixed Issues
$ #78100
PROPOSAL: #78100 (comment)
Tests
Precondition:
Offline tests
None
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-02.at.08.44.31.mov
Android: mWeb Chrome
Screen.Recording.2026-01-02.at.08.51.32.mov
iOS: Native
Screen.Recording.2026-01-02.at.08.52.35.mov
iOS: mWeb Safari
Screen.Recording.2026-01-02.at.08.45.55.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-02.at.12.52.10.mov