[No QA] Remove unused beta constants

[neil-marcellini]

Explanation of Change

I noticed this really old beta constant p2pDistanceRequests was still in the code. I checked over all of them and found a couple more that aren't referenced anywhere, so they are all removed to keep things tidy.

Fixed Issues

N/A

Tests

N/A

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

No QA

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

Code Review Summary

I've reviewed PR #78753 and found critical issues that need to be addressed before merging.

❌ Critical Issues Found

1. SPOTNANA_TRAVEL constant is still in use

The constant CONST.BETAS.SPOTNANA_TRAVEL that you're attempting to remove is actually still referenced in the codebase as CONST.BETAS.PREVENT_SPOTNANA_TRAVEL. This constant is actively used in:

• tests/unit/usePermissionsTest.tsx (lines 50, 55, 67, 75, 82)
• src/components/BookTravelButton.tsx (line 88)
• src/pages/Travel/TravelTerms.tsx (line 42)
• src/pages/Travel/TripDetailsPage.tsx (line 46)
• src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx (line 180)

2. TIME_TRACKING constant is still in use

The constant CONST.BETAS.TIME_TRACKING that you're removing is NOT the only TIME_TRACKING constant. There's also:

• CONST.TIME_TRACKING object (line 1790 in CONST/index.ts) which contains units like hours
• CONST.TIME_TRACKING.UNIT is actively used in src/types/onyx/Transaction.ts (line 87)

✅ Safe to Remove

Only P2P_DISTANCE_REQUESTS appears to be truly unused and safe to remove.

Recommendation

This PR should be updated to:

1. Remove only P2P_DISTANCE_REQUESTS
2. Keep SPOTNANA_TRAVEL and TIME_TRACKING as they are still in use

The removal of SPOTNANA_TRAVEL and TIME_TRACKING will break the build and cause runtime errors.

[github-actions]

Additional Analysis

I also verified the string values themselves:

• 'p2pDistanceRequests' ✅ - Only found in CONST definition (safe to remove)
• 'spotnanaTravel' ✅ - Only found in CONST definition
• 'timeTracking' ✅ - Only found in CONST definition

However, the issue is that while the string values aren't used, the constant keys themselves (CONST.BETAS.SPOTNANA_TRAVEL and CONST.TIME_TRACKING) are still actively referenced in the codebase.

This means:

1. SPOTNANA_TRAVEL: Cannot be removed - it's confused with PREVENT_SPOTNANA_TRAVEL which is still in use
2. TIME_TRACKING: Cannot be removed - there's a separate CONST.TIME_TRACKING object (not just the beta) that's still in use
3. P2P_DISTANCE_REQUESTS: Safe to remove ✅

[github-actions]

Correction to Previous Review

I need to correct my previous analysis. After more thorough verification:

✅ All Three Constants Are Safe to Remove

My initial analysis was incorrect. Here's the corrected assessment:

1. P2P_DISTANCE_REQUESTS ✅ Safe to remove - no references found
2. SPOTNANA_TRAVEL ✅ Safe to remove - the references I found were for PREVENT_SPOTNANA_TRAVEL (a different constant that remains in the code)
3. TIME_TRACKING (beta) ✅ Safe to remove - this is CONST.BETAS.TIME_TRACKING, which is different from CONST.TIME_TRACKING (the object at line 1790 that contains time units)

Verification Results

• CONST.BETAS.SPOTNANA_TRAVEL - No references found (distinct from CONST.BETAS.PREVENT_SPOTNANA_TRAVEL)
• CONST.BETAS.TIME_TRACKING - No references found (distinct from CONST.TIME_TRACKING object)
• CONST.BETAS.P2P_DISTANCE_REQUESTS - No references found

All three beta constants are indeed unused and this PR is correct. My apologies for the confusion in my previous comments.

[github-actions]

✅ Final Review: APPROVED

After thorough verification, this PR correctly removes three unused beta constants:

Changes Summary

• ✅ Removes P2P_DISTANCE_REQUESTS: 'p2pDistanceRequests'
• ✅ Removes SPOTNANA_TRAVEL: 'spotnanaTravel'
• ✅ Removes TIME_TRACKING: 'timeTracking'

Verification

• No references to CONST.BETAS.P2P_DISTANCE_REQUESTS found
• No references to CONST.BETAS.SPOTNANA_TRAVEL found (PREVENT_SPOTNANA_TRAVEL is a separate constant)
• No references to CONST.BETAS.TIME_TRACKING found (CONST.TIME_TRACKING object is separate)

Code Quality

• ✅ Clean removal with no side effects
• ✅ Helps maintain a tidy codebase
• ✅ No breaking changes

This is a good housekeeping PR. The changes are safe to merge.