-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[CP Staging] Revert "chore: Upgrade react-navigation to latest" #78443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Revert "chore: Upgrade react-navigation to latest" #78443
Conversation
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
❗ Please, do not use Github auto-linking keywords such as these: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved. For more details, see the Contributing Guidelines, specifically Submit your pull request for a final review 📖. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ### [@react-navigation+core+7.10.0+002+getStateFromPath.patch](@react-navigation+core+7.10.0+002+getStateFromPath.patch) | ||
| - Reason: Make sure navigation state props retrieved from the path are available at all nesting levels to avoid undefined state. | ||
| - Upstream PR/issue: N/A | ||
| - E/App issue: [#48150](https://github.com/Expensify/App/issues/48150) | ||
| - PR Introducing Patch: [#48151](https://github.com/Expensify/App/pull/48151) | ||
| - PR Updating Patch: [#64155](https://github.com/Expensify/App/pull/64155) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore missing getStateFromPath patch
The docs now call out @react-navigation+core+7.10.0+002+getStateFromPath.patch, but there is no such patch file in patches/react-navigation (checked via ls/rg getStateFromPath). That means the 7.10.0 downgrade ships without the prior fix from E/App#48150 where getStateFromPath populates nested navigation state when parsing deep-link paths, so nested routes parsed from URLs will still have undefined state entries. Please re-add the patch file or drop the reference if the fix is no longer needed.
Useful? React with 👍 / 👎.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…eact-navigation-to-latest [CP Staging] Revert "chore: Upgrade react-navigation to latest" (cherry picked from commit c210ff1) (cherry-picked to staging by jasperhuangg)
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.2.87-2 🚀
|
|
@jasperhuangg Web - passed. But there is no auto-focus after logout on native apps. Is it expected? Screenrecorder-2025-12-25-15-36-30-254.mp4 |
|
@izarutskaya I would expect auto focus to still happen on native. Is it the exact same behavior as what this deploy blocker outlined on web? Does it happen on prod? |
|
@jasperhuangg Yes, the same in Prod ScreenRecording_12-26-2025.7-52-40.AM_1.mp4Android Screen.Recording.20251226.081216.Expensify.mp4 |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.87-7 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.2.88-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.88-7 🚀
|
|
@izarutskaya ah I think it's fine, it doesn't seem like we display any errors to the user. Thanks for checking! |
Context
Reverts #76933
$ #78435
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari