fix manually entered message not shown #78297

Nodebrute · 2025-12-22T16:28:20Z

Explanation of Change

Fixed Issues

$ #77400
PROPOSAL: #77400 (comment)

Tests

Log in to Classic
Open any report and choose Pay manually
Enter a message/reason in the textbox (e.g., “Paid outside Expensify”)
Complete the manual payment
Switch to NewDot and open the same report
Verify the system message generated for the manual payment shows marked as paid, saying “Paid outside Expensify“

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Log in to Classic
Open any report and choose Pay manually
Enter a message/reason in the textbox (e.g., “Paid outside Expensify”)
Complete the manual payment
Switch to NewDot and open the same report
Verify the system message generated for the manual payment shows marked as paid, saying “Paid outside Expensify“

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-12-22.at.8.14.37.PM.mov

melvin-bot · 2025-12-22T16:28:25Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2025-12-22T16:28:56Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-22T17:57:47Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/OptionsListUtils/index.ts	`73.04% <0.00%> (ø)`
src/libs/ReportNameUtils.ts	`83.05% <0.00%> (+0.67%)`	⬆️
...ges/home/report/ContextMenu/ContextMenuActions.tsx	`0.78% <0.00%> (ø)`
src/pages/home/report/PureReportActionItem.tsx	`52.41% <0.00%> (ø)`
src/libs/ReportActionsUtils.ts	`52.84% <0.00%> (-0.11%)`	⬇️
src/libs/ReportUtils.ts	`73.02% <0.00%> (+0.03%)`	⬆️
... and 11 files with indirect coverage changes

Nodebrute · 2025-12-22T18:07:41Z

@situchan the pr is ready for review

situchan · 2025-12-25T15:26:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

situchan · 2025-12-25T15:27:13Z

@Nodebrute please merge main

situchan

There's missing case - threaded message

situchan · 2025-12-25T17:19:48Z

src/libs/ReportActionsUtils.ts

    return reportAction.originalMessage;
 }

+function getMarkedReimbursedComment(reportAction: OnyxInputOrEntry<ReportAction>): string | undefined {


Instead of this, define getMarkedReimbursedMessage in ReportActionsUtils which directly returns translated message.

return translateLocal('iou.paidElsewhere', {comment: originalMessage?.message?.trim()});

@situchan i have updated the code

situchan · 2025-12-25T17:43:46Z

Bug: name: mark as paid in LHN alternative text as soon as login.
After opening report, it's updated to the correct one You: marked as paid, saying "Paid outside Expensify"

Screen.Recording.2025-12-25.at.11.40.53.PM.mov

Nodebrute · 2025-12-29T08:45:20Z

Sorry, this got delayed due to the holidays. I’ll update today.

Nodebrute · 2025-12-30T09:07:57Z

There's missing case - threaded message

Fixed the threaded message case

Nodebrute · 2025-12-30T09:41:54Z

Bug: name: mark as paid in LHN alternative text as soon as login.
After opening report, it's updated to the correct one You: marked as paid, saying "Paid outside Expensify"

@situchan I’m not able to reproduce this issue on my end. What I’m seeing instead is “This chat is with Jane.” Could you please share the steps to consistently reproduce this issue?

Screen.Recording.2025-12-30.at.2.05.57.PM.mov

situchan · 2026-01-02T18:45:42Z

Bug: name: mark as paid in LHN alternative text as soon as login.
After opening report, it's updated to the correct one You: marked as paid, saying "Paid outside Expensify"

@situchan I’m not able to reproduce this issue on my end. What I’m seeing instead is “This chat is with Jane.” Could you please share the steps to consistently reproduce this issue?

Screen.Recording.2025-12-30.at.2.05.57.PM.mov

still reproducible. I just followed the steps in OP, logout and relogin on iOS

Screen.Recording.2026-01-03.at.12.43.28.AM.mov

situchan · 2026-01-02T19:10:56Z

Any reason for not migrating these places?

App/src/pages/home/report/PureReportActionItem.tsx

Line 1230 in a035280

    
           children = <ReportActionItemBasicMessage message={translate('iou.paidElsewhere')} />;

App/src/libs/ReportNameUtils.ts

Lines 471 to 473 in a035280

    
           if (originalMessage.paymentType === CONST.IOU.PAYMENT_TYPE.ELSEWHERE) { 
        
               // eslint-disable-next-line @typescript-eslint/no-deprecated 
        
               return translateLocal('iou.paidElsewhere');

App/src/libs/ReportUtils.ts

Line 5738 in a035280

return translateLocal('iou.paidElsewhere');

situchan · 2026-01-02T19:12:00Z

src/libs/ReportUtils.ts

        }
+        if (translatePhraseKey === 'iou.paidElsewhere') {
+            // eslint-disable-next-line @typescript-eslint/no-deprecated
+            return translateLocal(translatePhraseKey, {payer: payerDisplayName ?? undefined});


comment is missing?

same reason #78297 (comment)

situchan · 2026-01-02T19:12:37Z

src/libs/ReportUtils.ts

        if (translationKey === 'iou.paidElsewhere') {
            // eslint-disable-next-line @typescript-eslint/no-deprecated
-            return translateLocal(translationKey, '');
+            return translateLocal(translationKey);


Any reason for not migrating this?

same reason #78297 (comment)

situchan · 2026-01-02T19:16:13Z

Bug: name: mark as paid in LHN alternative text as soon as login.
After opening report, it's updated to the correct one You: marked as paid, saying "Paid outside Expensify"

@situchan I’m not able to reproduce this issue on my end. What I’m seeing instead is “This chat is with Jane.” Could you please share the steps to consistently reproduce this issue?
Screen.Recording.2025-12-30.at.2.05.57.PM.mov

still reproducible. I just followed the steps in OP, logout and relogin on iOS

Screen.Recording.2026-01-03.at.12.43.28.AM.mov

Other way to reproduce: clear cache and restart

Screen.Recording.2026-01-03.at.1.15.21.AM.mov

Nodebrute · 2026-01-06T19:23:14Z

Any reason for not migrating these places?

These places deal with IOU actions where paymentType === ELSEWHERE, which is different from MARKED_REIMBURSED actions. The original issue was about MARKED_REIMBURSED actions in Classic, where comments were being stored in originalMessage.message. Here, we just show the standard "paid elsewhere" message instead of any user comments. Since the problem was only with MARKED_REIMBURSED and these are separate flows, there’s no need to change anything for IOU actions with paymentType === ELSEWHERE.

Nodebrute · 2026-01-06T19:52:00Z

Other way to reproduce: clear cache and restart

Screen.Recording.2026-01-07.at.12.39.12.AM.mov

@situchan Tested on old and new accounts, still unable to reproduce. Even tested on android and ios, same results.

situchan · 2026-01-06T19:58:55Z

Other way to reproduce: clear cache and restart

Screen.Recording.2026-01-07.at.12.39.12.AM.mov
@situchan Tested on old and new accounts, still unable to reproduce. Even tested on android and ios, same results.

ok let's not block on this as edge case and happening on production.

Nodebrute · 2026-01-06T20:00:16Z

resolved the conflicts. I think pr is ready to merge.

situchan · 2026-01-06T20:02:36Z

@Nodebrute

Nodebrute · 2026-01-06T20:44:08Z

@situchan the pr is ready

situchan · 2026-01-07T13:40:04Z

@Nodebrute conflicts

Nodebrute · 2026-01-08T17:56:20Z

@situchan conflicts resolved

OSBotify · 2026-01-08T18:34:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-09T20:01:36Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.2.97-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-10T02:20:43Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.2.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Nodebrute and others added 7 commits December 22, 2025 20:05

fix manually entered message not shown

628c04e

add comment param in all language files

7247715

fix unsafe type assertion

cc4c32a

Merge branch 'main' into fixmessage

e6c2540

create a utility function

89f93ec

run prettier

9349f05

fix lint

e0de801

Nodebrute requested review from a team as code owners December 22, 2025 16:28

melvin-bot bot assigned Nodebrute Dec 22, 2025

melvin-bot bot requested review from Julesssss and heyjennahay and removed request for a team December 22, 2025 16:28

Nodebrute marked this pull request as draft December 22, 2025 17:22

Nodebrute mentioned this pull request Dec 22, 2025

[$250] Manual Payment Reason Entered in Classic Does Not Appear in NewDot System Message #77400

Open

16 tasks

fix type error

116a2a5

Nodebrute marked this pull request as ready for review December 22, 2025 18:02

Nodebrute changed the title ~~Fixmessage~~ fix manually entered message not shown Dec 22, 2025

Julesssss requested a review from situchan December 22, 2025 21:31

situchan suggested changes Dec 25, 2025

View reviewed changes

situchan reviewed Dec 25, 2025

View reviewed changes

simplify getMarkedReimbursedMessage

00784d4

situchan reviewed Jan 2, 2026

View reviewed changes

Merge branch 'main' into fixmessage

15149ec

run prettier

12f68f5

situchan approved these changes Jan 6, 2026

View reviewed changes

melvin-bot bot requested a review from arosiclair January 6, 2026 20:01

Nodebrute and others added 2 commits January 7, 2026 01:20

Merge branch 'Expensify:main' into fixmessage

5abdfd0

fix lint

721050a

Nodebrute and others added 2 commits January 8, 2026 22:24

Merge branch 'main' into fixmessage

f44a70f

npm run prettier

3aa779e

situchan approved these changes Jan 8, 2026

View reviewed changes

arosiclair approved these changes Jan 8, 2026

View reviewed changes

arosiclair merged commit 1519e47 into Expensify:main Jan 8, 2026
32 checks passed

OSBotify mentioned this pull request Jan 9, 2026

Deploy Checklist: New Expensify 2026-01-09 #79227

Open

60 tasks

fix manually entered message not shown #78297

fix manually entered message not shown #78297

Conversation

Nodebrute commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 22, 2025

Uh oh!

melvin-bot bot commented Dec 22, 2025

Uh oh!

codecov bot commented Dec 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Nodebrute commented Dec 22, 2025

Uh oh!

situchan commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Dec 25, 2025

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

situchan Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Nodebrute Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

situchan commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nodebrute commented Dec 29, 2025

Uh oh!

Nodebrute commented Dec 30, 2025

Uh oh!

Nodebrute commented Dec 30, 2025

Uh oh!

situchan commented Jan 2, 2026

Uh oh!

situchan commented Jan 2, 2026

Uh oh!

situchan Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Nodebrute Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

situchan Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Nodebrute Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

situchan commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nodebrute commented Jan 6, 2026

Uh oh!

Nodebrute commented Jan 6, 2026

Uh oh!

situchan commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nodebrute commented Jan 6, 2026

Uh oh!

situchan commented Jan 6, 2026

Uh oh!

Nodebrute commented Jan 6, 2026

Uh oh!

Nodebrute commented Dec 22, 2025 •

edited

Loading

codecov bot commented Dec 22, 2025 •

edited by github-actions bot

Loading

situchan commented Dec 25, 2025 •

edited

Loading

situchan commented Dec 25, 2025 •

edited

Loading

situchan commented Jan 2, 2026 •

edited

Loading

situchan commented Jan 6, 2026 •

edited

Loading