[Duplicate Expenses] Add Distance Expense Support

[jjcoffee]

Explanation of Change

Adds support for distance expenses, with an additional BE fix for the case that was previously failing on the original PR - duplicating a distance expense from a non-default workspace. Previously this would return an error from the BE and the expense would not get added. Now we do add the expense and display an error about the rate being unavailable.

Fixed Issues

$ #77706
PROPOSAL: N/A

Tests

Same as QA steps.

• Verify that no errors appear in the JS console

Offline tests

Same as QA steps.

QA Steps

Prerequisites:

• Have at least two workspaces

1. Create a distance expense on the non-default workspace
2. Open the expense, go to More -> Duplicate
3. Go to the default workspace.
4. Verify that the expense from (1) is present in an open report or a new report if there wasn't an open one.
5. Verify that a Rate not valid for this workspace error shows up
6. Open the expense and verify that all the information is the same as the original expense, except for the date, which is set to today's date.
7. Go to More -> Duplicate.
8. Verify that a modal shows Fix the distance rate error and try again.
9. Tap Rate and correct the violation by selecting any rate.
10. Verify that the violation clears.
11. Go to More -> Duplicate and verify that no modal shows and the expense duplicates.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-app-2026-01-06_17.05.29.mp4

Android: mWeb Chrome

android-chrome-2026-01-06_17.08.41.mp4

iOS: Native

ios-app-2026-01-06_16.58.18.mp4

iOS: mWeb Safari

ios-safari-2026-01-06_17.01.08.mp4

MacOS: Chrome / Safari

desktop-chrome-2026-01-07_15.41.08.mp4

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportSecondaryActionUtils.ts	91.80% <100.00%> (ø)
src/libs/actions/IOU/index.ts	68.48% <100.00%> (+0.37%)	⬆️
src/libs/TransactionUtils/index.ts	72.26% <0.00%> (-0.15%)	⬇️
src/components/MoneyRequestHeader.tsx	0.00% <0.00%> (ø)
src/components/MoneyReportHeader.tsx	0.00% <0.00%> (ø)
... and 9 files with indirect coverage changes

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[jjcoffee]

Updated flow with modal:

desktop-chrome-2026-01-08_15.59.47.mp4

[melvin-bot]

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[jjcoffee]

Waiting for translation confirmation, but otherwise I think it's ready!

[joekaufmanexpensify]

Whats next project 👍

[jjcoffee]

@JS00001 Would you be able to run the generateTranslations job when you get a chance?

[JS00001]

Done

[OSBotify]

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

The diff is too large to include in this comment (282KB), so I've created a gist for you:

📋 View the translation diff here 📋

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply, or directly by running gh gist view --raw de15594cee55384a936e2e807fba34c1 | git apply 😉

[JS00001]

Please let us know when this one's ready! It'd be great if we could try and prioritize this review to get this in tomorrow before you're OOO

[jjcoffee]

@JS00001 It's ready!

[hoangzinh]

It will cause a bug when duplicating an unreported expense; it does nothing

Screen.Recording.2026-01-09.at.17.18.51.mov

[hoangzinh]

NAB: it should be great if we can add unit tests for this util

[hoangzinh]

Suggested change

	existingTransaction: {
	...(params.transactionParams ?? {}),
	comment: transaction.comment,
	iouRequestType: CONST.IOU.REQUEST_TYPE.DISTANCE,
	modifiedCreated: '',
	reportID: '1',
	transactionID: '1',
	},
	existingTransaction: transaction,

Shouldn't it be transaction?

[hoangzinh]

Bug: Duplicate manual distance expense incorrectly creates a cash expense

Screen.Recording.2026-01-09.at.17.37.55.mov

[hoangzinh]

Bug: Duplicating a map distance expense creates a distance expense with a different amount/distance

Screen.Recording.2026-01-09.at.17.46.111.mov

[hoangzinh]

Bug: [Offline] Duplicating a map distance expense creates a distance expense with an empty submitter and report name

Screen.Recording.2026-01-09.at.18.03.47.mov

[jjcoffee]

Sorry, heading OOO now so I'll have to handle these bugs when I'm back on the 16th.

[trjExpensify]

Welcome back, @jjcoffee. Can you fix the conflicts and resume this one?