-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: missing animations in #76890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing animations in #76890
Conversation
|
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
f9e9351 to
31e1be4
Compare
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
31e1be4 to
094e3e5
Compare
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
677cb7d to
074051f
Compare
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreenrecorder-2026-01-08-12-01-58-625.mp4Android: mWeb Chrome2026-01-08.11.33.28.moviOS: HybridAppIMG_3828.MP4iOS: mWeb Safari2026-01-08.11.29.04.movMacOS: Chrome / SafariNA |
|
It's a minor issue 2026-01-08.11.41.49.mov |
|
@ZhenjaHorbach yes, this is what @mountiny noticed as well! I think someone from Callstack already works on it/investigates it 👀 |
Good then |
|
@ZhenjaHorbach Nice, how is it looking? |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
For me, it looks good |
|
But I can approve it anyway! |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@kirillzyusko There must be a problem with your device. Please replace with this file. I run pod locally on this branch. |
@situchan |
Standalone pods but should not be a matter. |
|
We should also update Podfile.lock in Mobile-Expensify along with merging this PR. |
|
Can you please raise the Mobile-Expensify PR with the podfile changes too? |
I know |
ok then what's the issue? Seems all good. |
I'm pretty sure that @kirillzyusko installed hybrid pods |
|
Here's hybrid pod: (to be added in Mobile-Expensify/iOS) |
f6add51 to
e1495a0
Compare
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Explanation of Change
Updated keyboard controller to the latest version that contains a fix for #75139 bug
Fixed Issues
$ #75139
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-01-06.at.13.31.44.mov
iOS: mWeb Safari
MacOS: Chrome / Safari