Make `SplitExpensePage` use new `SelectionList` #75289

zfurtak · 2025-11-17T11:56:49Z

Explanation of Change

Fixed Issues

$ #72972
PROPOSAL:

Tests

Create an expense in a workspace
Go to page of this report.
Choose More -> Split
Add more splits to have a scrollable list
Verify that it's working correctly on different tabs

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

screen-20251208-160200.2.mp4

Android: mWeb Chrome

screen-20251208-161000.mp4

iOS: Native

Screen.Recording.2025-12-08.at.16.21.39.mov

iOS: mWeb Safari

Screen.Recording.2025-12-08.at.16.19.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-17.at.15.44.53.mov

MacOS: Desktop

codecov · 2025-11-17T12:08:18Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ponents/Search/FilterDropdowns/UserSelectPopup.tsx	`4.25% <ø> (ø)`
...omponents/SelectionList/ListItem/SplitListItem.tsx	`0.00% <ø> (ø)`
...List/ListItem/SplitListItem/SplitAmountDisplay.tsx	`0.00% <ø> (ø)`
...onList/ListItem/SplitListItem/SplitAmountInput.tsx	`0.00% <ø> (ø)`
...List/ListItem/SplitListItem/SplitListItemInput.tsx	`0.00% <ø> (ø)`
.../ListItem/SplitListItem/SplitPercentageDisplay.tsx	`0.00% <ø> (ø)`
...st/ListItem/SplitListItem/SplitPercentageInput.tsx	`0.00% <ø> (ø)`
src/components/SelectionListWithModal/index.tsx	`88.88% <ø> (ø)`
src/pages/AddUnreportedExpense.tsx	`0.00% <ø> (ø)`
...AdvancedFiltersPage/SearchFiltersWorkspacePage.tsx	`0.00% <ø> (ø)`
... and 7 more
... and 3 files with indirect coverage changes

src/components/SelectionList/BaseSelectionList.tsx

zfurtak · 2025-12-09T12:07:31Z

src/components/SelectionList/BaseSelectionList.tsx

+
+        // Delay scrolling by 100ms to allow the keyboard to open.
+        // This ensures FlashList calculates the correct window size.
+        setTimeout(() => {


This solution is only temporary because KeyboardAwareScrollView does not currently work well with FlashList v2.

The average time it takes for the keyboard to fully open is 300 ms

Can we remove setTimeout in BaseSelectionListWithSections? We don't have setTimeout, so if we can still reproduce this issue in staging, we don't need to add timeout

I'm not sure if I understand 🤔
With the previous SelectionListWithSections we used a different approach that involved a custom hook to accurately calculate the window size (useDisplayFocusedInputUnderKeyboard) for mWeb and KeyboardAwareScrollView for natives.
However the current solution doesn't work well cause KeyboardAwareScrollView is not very compatible with FlashList v2.
So the core problem is a FlashList timing issue:

it calculates the available window size too early

it attempts to scroll to the target element before the on-screen keyboard has finished opening

the calculated scrolling position is incorrect

Adding the 300 ms delay (which is the average time for the keyboard to appear on most Android and iOS phones) ensures that FlashList waits long enough to calculate the final, correct screen size (with the keyboard fully visible) before executing the scroll, allowing it to move to the proper location

Oh sorry @zfurtak, I mean

Can we remove setTimeout? In BaseSelectionListWithSections we don't have setTimeout, so if we can still reproduce this issue on staging, we don't need to add a timeout

On staging it's not reproducible because the other workaround works there, with FlashList it doesn't work properly 😕

Thank you, I got it

dukenv0307 · 2025-12-15T12:11:48Z

@zfurtak code looks good. Can you please merge main? Then I'll test it

zfurtak · 2025-12-16T09:08:03Z

@dukenv0307 merged and ready :)

dukenv0307 · 2025-12-16T12:19:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-08.at.09.47.46.mov

Android: mWeb Chrome

Screen.Recording.2025-12-16.at.19.16.12.mov

iOS: HybridApp

Screen.Recording.2026-01-08.at.09.50.55.mov

iOS: mWeb Safari

Screen.Recording.2025-12-16.at.19.15.12.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-16.at.19.13.11.mov

dukenv0307 · 2025-12-16T12:23:03Z

Bug: the focused input scrolls up a bit then scrolls to bottom

this PR

Screen.Recording.2025-12-16.at.19.18.16.mov

Screen.Recording.2025-12-16.at.19.18.33.mov

main/staging:

Screen.Recording.2025-12-16.at.19.20.37.mov

Screen.Recording.2025-12-16.at.19.20.53.mov

grgia

Running a test build

heyjennahay · 2025-12-24T11:45:29Z

No product UI change so removing product reviewer

grgia

@zfurtak would you merge main here and address lint for final review please 🙇

zfurtak · 2026-01-07T09:08:29Z

I'm back and on it 😊

zfurtak · 2026-01-07T16:14:01Z

Should be better now, @dukenv0307 could you retest it?

github-actions · 2026-01-08T12:09:49Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-08T12:36:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #75289.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9f74f9780d2afaf4028845a6f7f257bbce936340/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4c166ad78f76d786c8e438850c631c31a71c8d67/index.html

Web 🕸️
https://75289.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-01-09T11:21:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Make SplitExpensePage use new SelectionList

c2f323d

melvin-bot bot assigned zfurtak Nov 17, 2025

zfurtak mentioned this pull request Nov 17, 2025

[Due for payment 2025-12-10] [Due for payment 2025-12-05] [Due for payment 2025-12-03] Migrate Wave 4 #72970

Open

zfurtak added 4 commits November 17, 2025 15:39

Fix importing icons

2a38f6e

Remove old SplitListItem

22f44a1

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

5a41e3e

Try to fix scrolling

4d08344

grgia self-requested a review November 19, 2025 09:34

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

5a39025

zfurtak mentioned this pull request Dec 2, 2025

Migrate Wave 5 #72972

Open

zfurtak added 8 commits December 4, 2025 15:55

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

a1f0f75

Change logic of focusing chosen input

b57e7e5

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

c5ce478

Adjust

90a03c9

Adjust comments

8e4de13

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

aa12e6c

Adjust refs

e825834

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

35687cb

blazejkustra approved these changes Dec 8, 2025

View reviewed changes

Adjustments

92a1adb

collectioneur approved these changes Dec 9, 2025

View reviewed changes

collectioneur reviewed Dec 9, 2025

View reviewed changes

src/components/SelectionList/BaseSelectionList.tsx Outdated Show resolved Hide resolved

zfurtak added 3 commits December 9, 2025 12:57

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

a0fc0c4

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

af70dca

Adjust to review

94037c9

zfurtak commented Dec 9, 2025

View reviewed changes

zfurtak marked this pull request as ready for review December 9, 2025 12:07

zfurtak requested review from a team as code owners December 9, 2025 12:07

zfurtak added 3 commits December 16, 2025 08:36

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

4ddae38

Fix ts

f914d0c

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

c26c891

grgia reviewed Dec 18, 2025

View reviewed changes

heyjennahay removed their request for review December 24, 2025 11:45

grgia reviewed Jan 5, 2026

View reviewed changes

zfurtak force-pushed the @zfurtak/migrate-SplitExpensePage branch from 2be0c8d to c26c891 Compare January 7, 2026 10:31

zfurtak added 4 commits January 7, 2026 12:52

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

8821571

Adjust after merge

47870ef

Adjust file after merge

f21648d

Fix double scroll

c9a0583

dukenv0307 approved these changes Jan 8, 2026

View reviewed changes

melvin-bot bot requested a review from grgia January 8, 2026 02:52

grgia previously approved these changes Jan 8, 2026

View reviewed changes

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

a671ff2

zfurtak dismissed grgia’s stale review via a671ff2 January 8, 2026 17:23

zfurtak added 2 commits January 9, 2026 11:23

Fix ts errors

4547ff7

Merge branch 'main' into @zfurtak/migrate-SplitExpensePage

cbf5ff4

grgia approved these changes Jan 9, 2026

View reviewed changes

grgia merged commit ae86ace into Expensify:main Jan 9, 2026
30 checks passed

Make SplitExpensePage use new SelectionList #75289

Make SplitExpensePage use new SelectionList #75289

Uh oh!

Conversation

zfurtak commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

zfurtak Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

zfurtak Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zfurtak Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Dec 15, 2025

Uh oh!

zfurtak commented Dec 16, 2025

Uh oh!

dukenv0307 commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Dec 16, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

heyjennahay commented Dec 24, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

zfurtak commented Jan 7, 2026

Uh oh!

zfurtak commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Make `SplitExpensePage` use new `SelectionList` #75289

Make `SplitExpensePage` use new `SelectionList` #75289

zfurtak commented Nov 17, 2025 •

edited

Loading

codecov bot commented Nov 17, 2025 •

edited by github-actions bot

Loading

dukenv0307 Dec 11, 2025 •

edited

Loading

dukenv0307 commented Dec 16, 2025 •

edited

Loading