feat: Remote Registry Support #294
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zabarn
changed the title
EXPEbdodla
reviewed
Sep 3, 2025
EXPEbdodla
reviewed
Sep 3, 2025
Collaborator
EXPEbdodla
left a comment
EXPEbdodla
left a comment
There was a problem hiding this comment.
Add a test cases. Rest all looking good to me.
zabarn
force-pushed
the
feature/remote-registry-updates
branch
from
0082406 to
778bcb7
Compare
added 9 commits
January 13, 2026 13:29
EXPEbdodla
reviewed
Jan 20, 2026
| applyCommand.Dir = featureRepoPath | ||
| out, err := applyCommand.CombinedOutput() | ||
| if err != nil { | ||
| log.Printf("Repo setup error: %s", string(out)) |
EXPEbdodla
reviewed
Jan 20, 2026
Comment on lines
+263
to
+274
| // Verify registry.db was created with retries | ||
| registryPath := filepath.Join(dataDir, "registry.db") | ||
| for i := 0; i < 10; i++ { | ||
| if _, err := os.Stat(registryPath); err == nil { | ||
| log.Printf("Registry file created successfully after %d attempts", i+1) | ||
| break | ||
| } | ||
| if i == 9 { | ||
| return fmt.Errorf("registry.db was not created after feast apply") | ||
| } | ||
| time.Sleep(1 * time.Second) | ||
| } |
EXPEbdodla
reviewed
Jan 20, 2026
|
|
||
| message ExpediaSearchFeatureViewsRequest { | ||
| string search_text = 1; | ||
| google.protobuf.BoolValue online = 2; |
Collaborator
There was a problem hiding this comment.
write a comment when we are not using bool type.
EXPEbdodla
reviewed
Jan 20, 2026
Comment on lines
+632
to
+633
| int32 total_projects = 3; | ||
| int32 total_page_indices = 4; |
EXPEbdodla
reviewed
Jan 20, 2026
| def ExpediaSearchFeatureViews( | ||
| self, request: RegistryServer_pb2.ExpediaSearchFeatureViewsRequest, context | ||
| ): | ||
| # Using `type: ignore[attr-defined]` because this should only be implemented in sql registry. |
Collaborator
There was a problem hiding this comment.
proxied_registry should be SQL Registry or SQL Fallback registry. Throw error if its different registry type.
EXPEbdodla
reviewed
Jan 20, 2026
| path="/tmp/multi_view_sink", | ||
| file_format="parquet", | ||
| timestamp_field="daily_driver_stats__event_timestamp", | ||
| created_timestamp_column="daily_driver_stats__created", |
Collaborator
There was a problem hiding this comment.
Why do we need to remove created_timestamp_column?
EXPEbdodla
reviewed
Jan 20, 2026
|
|
||
| @pytest.fixture(scope="session") | ||
| def sqlite_registry(): | ||
| @pytest.fixture(scope="function") |
Collaborator
There was a problem hiding this comment.
check why we need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes https://expediagroup.atlassian.net/browse/EAPC-19174
Misc