Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Bug Fixes for @exodus/bytes

Issues Found:

  • Bug feat: add utf8 support #1: UTF-32 error message incorrectly says "Expected even number of bytes" when it should say "Expected length to be a multiple of 4" (lines 35, 40 in utf32.js)
    • When a user passes 6 bytes (which is even), the error is misleading
    • The check is % 4 !== 0 but the message said "even number"
    • Fixed: Changed error message to "Expected length to be a multiple of 4"

Completed:

  • Reviewed entire codebase for bugs and mistakes
  • Fixed UTF-32 error messages in utf32.js
  • Manually verified the fix works correctly
  • Code review completed - no issues found
  • Security scan completed - no vulnerabilities found
  • Removed package-lock.json and added to .gitignore (per review feedback)

Security Summary:

No security vulnerabilities were found in the changes or existing code.

Original prompt

This section details on the original issue you should resolve

<issue_title>Review the codebase and identify mistakes</issue_title>
<issue_description>Ignore tests/wpt and other vendored tests

Note: wif using synchronous path for async implementation is not an issue, it's done for perf, as underlying method is always sync (again, for perf).</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 28, 2026 12:03
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Copilot AI changed the title [WIP] Review codebase and identify mistakes Fix UTF-32 error message: "even number of bytes" → "multiple of 4" Jan 28, 2026
Copilot AI requested a review from ChALkeR January 28, 2026 12:12
@ChALkeR ChALkeR changed the title Fix UTF-32 error message: "even number of bytes" → "multiple of 4" fix: utf-32 error message: "even number of bytes" → "multiple of 4" Jan 28, 2026
Copy link
Collaborator

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot We use pnpm. Remove package-lock and add it to .gitignore, directly below node_modules

Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 28, 2026

@copilot We use pnpm. Remove package-lock and add it to .gitignore, directly below node_modules

Done in 4c659a9. Removed package-lock.json and added it to .gitignore below node_modules.

Copilot AI requested a review from ChALkeR January 28, 2026 12:17
@ChALkeR ChALkeR marked this pull request as ready for review January 28, 2026 12:19
@ChALkeR ChALkeR merged commit 7f0ad72 into main Jan 28, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review the codebase and identify mistakes

2 participants