Skip to content

Improvements from review #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nedtaylor merged 38 commits into from
Oct 23, 2024
Merged

Improvements from review #22

nedtaylor merged 38 commits into from
Oct 23, 2024

Conversation

@nedtaylor
Copy link
Collaborator

@nedtaylor nedtaylor commented Oct 23, 2024 •
edited
Loading

Implement recommended changes from Steve Hepplestone's code review.

Main changes to implement:

  • mod_generator
  • improve comments
  • mod_evaluator
  • improve commenting
  • Separate 2-body viability evaluation into its own procedure
  • Look into whether 2-body list generation can be separated into own procedure (won't do for now, would slow down code massively)
  • mod_evolver
  • rename module
  • split module into three modules (base, host, and container)
  • mod_edit_geom
  • split into two modules, basis_merge and get_distance procedures
  • mod_elements
  • rename module
  • improve comments
  • mod_error_handling
  • rename module
  • improve comments
  • mod_atom_adder
  • rename module
  • split into two modules, placement procedures and viability procedures
  • improve comments
  • general
  • rename gvectors to distribs
  • replace suitability references with viability
  • convert from real12 to real32

@nedtaylor
Improve commenting and formatting
17ad738
@nedtaylor
Add walk step size variables
902afc8
@nedtaylor
Remove unused checks
5634a9f
@nedtaylor
Add comments
362f66c
@nedtaylor
Remove unused pi
190af4f
@nedtaylor
Add 2body procedure
64c8a1b
@nedtaylor
Move host element map to call to generator
6992f41
@nedtaylor
Fix error handling
984e6da
@nedtaylor
Add missing initialisation
19081c9
@nedtaylor
Fix missing variable
7816d7f
@nedtaylor
Split evolver into three separate module files
614fab2
@nedtaylor
Add raffle__ prefix to module names
dd772b4
@nedtaylor
Fix set host
71971ec
@nedtaylor
Fix comments
ab8b148
@nedtaylor
Change real12 to real32
ae97ba2
@nedtaylor
Split edit_geom into two modules
67f240c
@nedtaylor
Rename raffle__rw_geom to raffle__geom_rw
d5c7af0
@nedtaylor
Rename elements to raffle__element_utils
ed4aa6a
@nedtaylor
Add comments
9f769ff
@nedtaylor
Add walk step size parameters
159811f
@nedtaylor
Split add_atom into two modules
b405367
@nedtaylor
Fix geom_rw rename
1bd0193
@nedtaylor
Remove unused module imports
caab918
@nedtaylor
Rename total to gdf in distribs_container_type
e4bc1b4
@nedtaylor
Rename extended_geom to raffle__geom_extd
1413186
@nedtaylor
Fix element_utils reference
b2e7c37
@nedtaylor
Replace rw_geom with geom_rw
d1bb589
@nedtaylor
Fix missing line continuation symbols
d759d8f
@nedtaylor
Standardise module names
7a04c03
@nedtaylor
Update ignore list
bc6c33a
@nedtaylor nedtaylor added the documentation Improvements or additions to documentation label Oct 23, 2024
@nedtaylor nedtaylor added this to the Version 1 milestone Oct 23, 2024
@nedtaylor nedtaylor self-assigned this Oct 23, 2024
@nedtaylor nedtaylor merged commit 415066a into main Oct 23, 2024
@nedtaylor nedtaylor deleted the improvements_from_review branch October 23, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nedtaylor nedtaylor

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

Version 1

Development

Successfully merging this pull request may close these issues.

2 participants

@nedtaylor