[3.0] Rewrite NameUtils.Prettify #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly works, but decided I want to try another approach.
…ingChangesInFormatEnums
…s might read better
…llowingNumbers_WhenAffixesDeclared
…ct, but non-ideal; the NameAffix code handles this case separately)
Also currently trying to ensure old behavior before changing things, so the number x number change has been reverted for now.
Merged
4 tasks
These changes are expected because the default acronym threshold is now 2 and the suffixes are not declared as NameAffixes.
[3.0] Change acronym threshold to 2 for all bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
A short summary of this PR and what it adds/removes/fixes.
Related issues, Discord discussions, or proposals
Links go here.
Further Comments