refactor: decouple Memory from asyncpg via StorageBackend protocol#3
Draft
refactor: decouple Memory from asyncpg via StorageBackend protocol#3
Conversation
Decouple pgkg from direct asyncpg usage by defining a StorageBackend protocol in pgkg/backend.py and a PostgresBackend implementation that wraps the existing asyncpg pool and SQL functions (pgkg_search, pgkg_link_entity, pgkg_bump_access) with zero behavioural change.
Memory now depends on the StorageBackend protocol instead of holding an asyncpg.Pool directly. All raw SQL has moved into PostgresBackend. PostgresExtractCache replaced by BackendExtractCache adapter. Updated api.py, cli.py, bench scripts, and tests to construct PostgresBackend.
Thread asserted_at through StoredChunk, StoredProposition, Candidate, and Result so the refactored backend preserves the feature added in origin/main. Fix test_bench and test_memory to use backend fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a StorageBackend protocol in pgkg/backend.py and a PostgresBackend implementation that wraps the existing asyncpg pool and SQL functions with zero behavioural change. Memory now depends on the protocol instead of holding an asyncpg.Pool directly. All raw SQL moved into PostgresBackend. PostgresExtractCache replaced by a BackendExtractCache adapter. 56/56 tests passing.