feat: Add raycasting from players perspective.#786
feat: Add raycasting from players perspective.#786Saskyc wants to merge 6 commits intoExMod-Team:masterfrom
Conversation
Mr-Baguetter
left a comment
There was a problem hiding this comment.
Looks good to me.
I dont see any obvious issues.
…ad of "Player" as Yamato suggested
louis1706
left a comment
There was a problem hiding this comment.
i just would like to test GetRaycastedPlayer just in case but should be good
I will make branch in Exiled Test and attach link to the branch with video. |
say me when done |
michcio15
left a comment
There was a problem hiding this comment.
Could you also add trygetraycastplayer will notnullwhen true so its cleaner (personal preference)
And also add native usage of LayerMasks enum
|
I can agree on making those methods return bool instead of actual value. In most cases devs would still need to check if returned value is not null, and by making methods return bool we simplify those checks |
that actually a very great idea |
… or anything in layer mask.
Description
Describe the changes
Adds new method to raycast from players CameraTransform.
Either for anything with layermask or for player & hitbox with predefined layermasks.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
None.
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other