MID-10966 Preserve resource edits after test connection#669
Open
kay1313 wants to merge 1 commit into
Open
Conversation
Closing the Test connection result popup refreshed the whole resource details page, recreating the resource wrapper from repository state and discarding unsaved capability changes. Let the popup close without triggering the resource details refresh, keeping the current wrapper and pending deltas intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed MID-10966, where unsaved changes in resource details could be lost after running Test connection.
The Test connection result popup previously refreshed the whole resource details page when the popup OK button was clicked. On
PageResource, this recreated the resource details model/wrapper from repository state, which discarded pending unsaved changes, for example changes in the resource capabilities list.The popup now closes without triggering the resource details refresh, so the current
PrismObjectWrapperand pending deltas stay intact.Testing
Added GUI integration test coverage for the Test connection popup flow.
The test opens a resource details page, runs Test connection, closes the result popup, and verifies that the resource details wrapper was not reloaded.