Skip to content

Conversation

@OjaswaGarg
Copy link

Add logic for Charging Station and Battery Robots in Labyrinth Editor. Also added an example layer and Logic Demo.

Copy link
Owner

@EvgSkv EvgSkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great overall!
I found a couple minor issues. Please fix and check if there are things like these :-)
Thank you!

if (dist < BEACON_HIT_RADIUS) {
return { distance: d, object: 'beacon', label: body.name };

return { distance: d, object: 'beacon', label: body.name + post_fix };
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not create the tech debt here. We can simply be assuming that level author adds appropriate postfix.

align-items: center;
font-size: 1.5rem;
color: #d1d5db; /* text-gray-300 */
color: #d1d5db;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went off here. Comments should go back to their lines :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants