feat(code-review): add thematic triage grouping#845
Open
jblwilliams wants to merge 1 commit into
Open
Conversation
Collaborator
|
@jblwilliams I'd like to see a few examples of output if you can provide it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional thematic grouping to
ce-code-reviewso related findings are easier to triage together instead of as one long flat list.The existing severity tables and stable finding IDs stay as the source of truth, but reviews can now include a short
Triage Groupssection that explains which findings are related, why they matter as a theme, and what order they should be handled in.Why
On larger reviews, the finding count can easily get into the double digits. A lot of those issues are often related, and one design decision or fix can resolve several of them at once. Grouping gives developers more context about the shape of the feedback so they do not have to work through 20 or 30 individual findings as if each one were independent.
Changes
grouping:auto,grouping:off, andgrouping:always