fix(ce-plan): inline synthesis gate output into SKILL.md#822
Open
tmchow wants to merge 2 commits into
Open
Conversation
The Phase 0.7 / 5.1.5 synthesis gate was being skipped silently when the synthesis-summary.md reference did not load — the templates and mandatory-announce rule lived only there, behind a "STOP, read this" indirection that the agent could (and did) skip. Move the load-bearing pieces inline so the gate fires reliably even on a load-failure case, and reorder the gate block so the reference-load instruction is the first step. The reference now provides best-effort quality guidance for call-out shaping; the gate itself no longer depends on it loading. Also fix the inlined templates: replace "Phase 0.4 bootstrap" / "Phase 1 research" with user-facing language (users do not track phase numbers), reduce two-bullet placeholders to a single placeholder with explicit count guidance (the multi-bullet placeholder biased toward a fixed count), and add purpose context to the Stated / Inferred / Out of scope bucket names so it is clear they drive plan-body routing rather than chat output.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a24e092abe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…plate Address PR review feedback (#822) The inlined solo template dropped the "(You can also redirect to /ce-brainstorm if this is bigger than you initially thought...)" parenthetical that the reference template carries. Inlining was supposed to make the gate fire reliably without the reference loading, so dropping the escape-hatch line from the inline copy weakened the guardrail it was meant to preserve. Sync the inline template back to the reference's wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synthesis gate at Phase 0.7 / 5.1.5 now fires reliably without depending on the synthesis-summary.md reference loading. The literal templates and the "silent proceeding is not allowed" rule are inlined in SKILL.md so the gate output appears even on a load-failure case. The gate block leads with a firm read-the-reference instruction so call-outs are still well-shaped when the load succeeds.
The inlined templates also drop phase-number jargon from user-facing text ("Phase 0.4 bootstrap" became "our brief discussion"), reduce a two-bullet placeholder that was biasing call-out count, and add purpose context to the Stated / Inferred / Out of scope bucket names.