Skip to content

Conversation

@maddie480
Copy link
Member

Tested on this PR: #915 because it needed to target a branch that actually had the GitHub Actions yaml in order to run it.

The action:

  • Waits for the build to be completed on Azure, polling every minute, filtering on the commit SHA
  • Pulls the everest:vanilla Docker image, which is just Ubuntu with a bare-bones Celeste in it, and no Everest (despite the name). We can't pull an encrypted Celeste and decode it with a secret, because pull request pipelines don't have access to secrets, so here we go
  • Downloads the build artifact from Azure and installs Everest from it
  • Downloads CelesteTAS, the TAS files and the Strawberry Jam bundle ™️ from Banana Mirror (they're static, so a mod update breaking TASes won't break the build)
  • Runs Celeste with special command line parameters that tell CelesteTAS to run the TAS, write the report and close the game
  • Checks if the report says "success"

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Jun 4, 2025
@maddie480
Copy link
Member Author

This new shiny pipeline epicly failed because of an unrelated crash fixed in #913. 😅

@maddie480 maddie480 added the 4: should be squashed PR with a messy commit history that should be squash merged label Jun 6, 2025
@maddie480 maddie480 removed the 4: should be squashed PR with a messy commit history that should be squash merged label Jun 6, 2025
@Wartori54
Copy link
Member

I think that fetching the tas files from the repo, and checking out a hard coded commit could be better. Same thing with the CelesteTAS version, if it can be fetched from gb or GitHub releases.
That would be good for transparency, and also adds the ability for people without celestemodupdater access to bump and inspect versions more easily.

For the required mods for each run (such as the SJ bundle), I can't think of a better alternative, so it's probably fine as is.

@maddie480
Copy link
Member Author

fixed, only the pinned SJ bundle remains on celestemodupdater

@maddie480 maddie480 force-pushed the github-tas branch 2 times, most recently from 2391dea to 2d5b7b2 Compare June 7, 2025 12:57
Copy link
Member

@psyGamer psyGamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable and should cover most obvious issues early. CelesteTAS also provides a utility program for simply executing the sync-check from a config file tho I suppose the features it provides aren't really useful to Everest (optionally installing latest version of an Everest branch, updating mods, better handling for running multiple TAS files, calculating a checksum to avoid repeated work) and therefore makes sense to use a custom script. For CelesteTAS a full sync-check is required before releasing (which takes 20min and therefore caching a nightly check is useful), but since Everest has structured it a bit differently, it seems reasonable.

Alright, enough rambling lmao

@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Jun 15, 2025, 12:00 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jun 11, 2025
@maddie480 maddie480 merged commit 2654371 into EverestAPI:dev Jun 14, 2025
3 checks passed
@maddie480 maddie480 deleted the github-tas branch June 14, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants