-
Notifications
You must be signed in to change notification settings - Fork 98
Run Celeste TASes on pull requests #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This new shiny pipeline epicly failed because of an unrelated crash fixed in #913. 😅 |
|
I think that fetching the tas files from the repo, and checking out a hard coded commit could be better. Same thing with the CelesteTAS version, if it can be fetched from gb or GitHub releases. For the required mods for each run (such as the SJ bundle), I can't think of a better alternative, so it's probably fine as is. |
|
fixed, only the pinned SJ bundle remains on celestemodupdater |
2391dea to
2d5b7b2
Compare
psyGamer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable and should cover most obvious issues early. CelesteTAS also provides a utility program for simply executing the sync-check from a config file tho I suppose the features it provides aren't really useful to Everest (optionally installing latest version of an Everest branch, updating mods, better handling for running multiple TAS files, calculating a checksum to avoid repeated work) and therefore makes sense to use a custom script. For CelesteTAS a full sync-check is required before releasing (which takes 20min and therefore caching a nightly check is useful), but since Everest has structured it a bit differently, it seems reasonable.
Alright, enough rambling lmao
|
The pull request was approved and entered the 3-day last-call window. |
Tested on this PR: #915 because it needed to target a branch that actually had the GitHub Actions yaml in order to run it.
The action: