Fix wrongly used value in enum handling in the settings menu#1101
Open
Wartori54 wants to merge 2 commits intoEverestAPI:devfrom
Open
Fix wrongly used value in enum handling in the settings menu#1101Wartori54 wants to merge 2 commits intoEverestAPI:devfrom
value in enum handling in the settings menu#1101Wartori54 wants to merge 2 commits intoEverestAPI:devfrom
Conversation
microlith57
approved these changes
Apr 5, 2026
Co-authored-by: microlith57 <microlith57@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default handling of
Enumas a setting mixed the value and the index of the value, causing enums which do not have the values auto assigned in c# to misbehave.This was first reported with an enum like following:
where the settings menu showed
Option1right after adding the setting to the class. This is due to mixing an internal index with the enum value.Furthermore, it also saved the wrong values in the yaml, due to it using the internal index, rather than the proper value associated with the selected enum value.