Skip to content

Conversation

@SnipUndercover
Copy link
Member

Closes #1043. Allows mappers to specify the texture of the postcard in the map's .meta.yaml, like so:

# relative to the Gui atlas
PostcardTexture: "SnipUndercover/EverestDevelopment/postcard"

If the texture does not exist, the __fallback texture will be displayed. Because the fallback texture is so small, most of the text will be cut off by it.

I suppose a next PR could let mappers change the color of the savedata name text that's rendered on the postcard to allow dark postcards?

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Jan 3, 2026
@SnipUndercover
Copy link
Member Author

It seems that GH and Azure can't agree on the commit hash. I'll push an empty commit.

@SnipUndercover
Copy link
Member Author

That jogged it just right, the TAS check is running.

@SnipUndercover SnipUndercover added the 4: should be squashed PR with a messy commit history that should be squash merged label Jan 3, 2026
Copy link
Member

@Wartori54 Wartori54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Together with allowing text color to be changed it would be nice to also add text repositioning in that upcoming PR for a more complete feature.

@SnipUndercover
Copy link
Member Author

Will create an issue and assign myself to it to not forget.

@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Jan 6, 2026, 8:00 PM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jan 3, 2026
@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Jan 6, 2026
@SnipUndercover
Copy link
Member Author

This will need a slight change in the .meta.yaml format to prepare for a future PR; do not merge yet.

@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@microlith57 microlith57 marked this pull request as draft January 9, 2026 09:22
@microlith57
Copy link
Member

marked as draft at @SnipUndercover's request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed) 4: should be squashed PR with a messy commit history that should be squash merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map-specific Postcard Textures

5 participants