-
Notifications
You must be signed in to change notification settings - Fork 97
Add "priority" attribute for "solid" decals #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "priority" attribute for "solid" decals #1030
Conversation
microlith57
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think priority is not a very descriptive name for the xml atrribute but otherwise this looks good
|
the TAS checks were cancelled? |
What about This PR LGTM if the naming complaint is addressed. |
I do believe we can always update the article on Decal Registry later to clarify what it's for |
Agreed. |
|
The pull request was approved and entered the 3-day last-call window. |
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
See #1029