Skip to content

Conversation

@SilverDorian46
Copy link
Contributor

See #1029

Copy link
Member

@microlith57 microlith57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think priority is not a very descriptive name for the xml atrribute but otherwise this looks good

@maddie480-bot maddie480-bot added the review needed This PR needs 2 approvals to be merged (bot-managed) label Nov 29, 2025
@SilverDorian46
Copy link
Contributor Author

the TAS checks were cancelled?

@Wartori54
Copy link
Member

i think priority is not a very descriptive name for the xml atrribute but otherwise this looks good

What about soundPriority?

This PR LGTM if the naming complaint is addressed.

@SilverDorian46
Copy link
Contributor Author

i think priority is not a very descriptive name for the xml atrribute but otherwise this looks good

What about soundPriority?

This PR LGTM if the naming complaint is addressed.

I do believe priority makes it more consistent with index, plus it's less characters to type, and with that it sort of strikes a good balance

we can always update the article on Decal Registry later to clarify what it's for

@Wartori54
Copy link
Member

i think priority is not a very descriptive name for the xml atrribute but otherwise this looks good

What about soundPriority?
This PR LGTM if the naming complaint is addressed.

I do believe priority makes it more consistent with index, plus it's less characters to type, and with that it sort of strikes a good balance

we can always update the article on Decal Registry later to clarify what it's for

Agreed.

@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Dec 28, 2025, 3:21 PM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed review needed This PR needs 2 approvals to be merged (bot-managed) labels Dec 25, 2025
@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added ready to merge This PR was approved and the last-call window is over (bot-managed) and removed last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Dec 28, 2025
@Wartori54 Wartori54 merged commit bc13caa into EverestAPI:dev Dec 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants