Skip to content

Add option to skip checking GameChecksum #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wartori54 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add option to skip checking GameChecksum #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Celeste.Mod.mm/Mod/Everest/Everest.Relinker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ public static class Relinker {
public static string GameChecksum => _GameChecksum = (_GameChecksum ?? Everest.GetChecksum(Assembly.GetAssembly(typeof(Relinker)).Location).ToHexadecimalString());
private static string _GameChecksum;

/// <summary>
/// Skips checking the GameChecksum when checking if mods should be relinked.
/// </summary>
internal static bool SkipGameChecksum;

/// <summary>
/// The lock which the relinker holds when relinking assemblies
/// </summary>
Expand Down
3 changes: 3 additions & 0 deletions Celeste.Mod.mm/Mod/Everest/Everest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ internal static void ParseArgs(string[] args) {
else if (arg == "--use-scancodes") {
Environment.SetEnvironmentVariable("FNA_KEYBOARD_USE_SCANCODES", "1");
}

else if (arg == "--no-game-checksum")
Relinker.SkipGameChecksum = true;
}
}

Expand Down
2 changes: 1 addition & 1 deletion Celeste.Mod.mm/Mod/Module/EverestModuleAssemblyContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ public static AsmChecksums ReadFromFile(string path) {
/// <returns>Whether this is compatible with <paramref name="other"/></returns>
public bool IsValidWith(AsmChecksums other) {
if (other == null) return false;
if (GameChecksum != other.GameChecksum) return false;
if (GameChecksum != other.GameChecksum && !Everest.Relinker.SkipGameChecksum) return false;
Copy link
Contributor

@DashingCat DashingCat Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe split the condition like this, so the current check remains identical after the change?

Suggested change
if (GameChecksum != other.GameChecksum && !Everest.Relinker.SkipGameChecksum) return false;
if (!Everest.Relinker.SkipGameChecksum)
if (GameChecksum != other.GameChecksum) return false;

if (FileChecksum != other.FileChecksum) return false;
if (SymFileChecksum != other.SymFileChecksum) return false;

Expand Down