Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new API for teleportation request events (PreTeleportRequestEvent and TeleportRequestEvent) and integrates them into the existing tpa and tpahere commands. The changes are logical and the new event API is well-defined.
However, I've found a few issues:
- There are duplicate registrations of a command and a listener in the example plugin, which could lead to bugs.
- More critically, there are several instances where a synchronous Bukkit event is being called from an asynchronous thread. This is a significant threading issue that can cause server instability and must be addressed.
My review includes detailed comments on these points with suggestions for how to resolve them.
eternalcore-core/src/main/java/com/eternalcode/core/feature/teleportrequest/TpaCommand.java
Outdated
Show resolved
Hide resolved
...ore-core/src/main/java/com/eternalcode/core/feature/teleportrequest/self/TpaHereCommand.java
Outdated
Show resolved
Hide resolved
...ore-core/src/main/java/com/eternalcode/core/feature/teleportrequest/self/TpaHereCommand.java
Outdated
Show resolved
Hide resolved
eternalcore-api-example/src/main/java/com/eternalcode/example/EternalCoreApiExamplePlugin.java
Outdated
Show resolved
Hide resolved
eternalcore-api-example/src/main/java/com/eternalcode/example/EternalCoreApiExamplePlugin.java
Outdated
Show resolved
Hide resolved
Jakubk15
requested changes
Feb 15, 2026
Comment on lines
13
to
14
| final Player sender = event.getSender(); | ||
| final Player target = event.getTarget(); |
Member
There was a problem hiding this comment.
Why is there a need to explicitly declare final?
Suggested change
| final Player sender = event.getSender(); | |
| final Player target = event.getTarget(); | |
| Player sender = event.getSender(); | |
| Player target = event.getTarget(); |
...rc/main/java/com/eternalcode/example/feature/teleportrequest/ApiTeleportRequestListener.java
Outdated
Show resolved
Hide resolved
eternalcore-api-example/src/main/java/com/eternalcode/example/EternalCoreApiExamplePlugin.java
Outdated
Show resolved
Hide resolved
eternalcore-api-example/src/main/java/com/eternalcode/example/EternalCoreApiExamplePlugin.java
Outdated
Show resolved
Hide resolved
...ore-core/src/main/java/com/eternalcode/core/feature/teleportrequest/self/TpaHereCommand.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/teleportrequest/TpaCommand.java
Outdated
Show resolved
Hide resolved
Rollczi
requested changes
Feb 21, 2026
Member
Rollczi
left a comment
There was a problem hiding this comment.
trzeba te eventy ogarnąć bo one są wołane async, a deklaracja jest false w konstruktorze - pytanie czy w sumie chcemy async może wolimy to sync dać
eternalcore-core/src/main/java/com/eternalcode/core/feature/teleportrequest/TpaCommand.java
Outdated
Show resolved
Hide resolved
Jakubk15
approved these changes
Feb 27, 2026
Comment on lines
+22
to
+27
| /* | ||
| if (!countryService.areInSameCountry(sender, target)) { | ||
| sender.sendMessage("You are not in the same country!"); | ||
| event.setCancelled(true); | ||
| } | ||
| */ |
Member
There was a problem hiding this comment.
???
Suggested change
| /* | |
| if (!countryService.areInSameCountry(sender, target)) { | |
| sender.sendMessage("You are not in the same country!"); | |
| event.setCancelled(true); | |
| } | |
| */ |
imDMK
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.