Properties: Superseded PropertyValues by Elementa's States (concept)#46
Draft
UserTeemu wants to merge 1 commit intoEssentialGG:masterfrom
Draft
Properties: Superseded PropertyValues by Elementa's States (concept)#46UserTeemu wants to merge 1 commit intoEssentialGG:masterfrom
UserTeemu wants to merge 1 commit intoEssentialGG:masterfrom
Conversation
31e167c to
a49648e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A concept implementation for using Elementa's
Stateobjects for storing values of properties.I was inspired to do this PR from improving #25 . The ability to have multiple listeners/actions added in this PR would help getting that other PR ready.
Major changes in this PR:
PropertyValues become deprecated.PropertyValue#initializedandPropertyValue#writeDataToFilehave been moved toPropertyDataPropertyCollector#getPropertyfunctions have been changed so that there would be less warnings caused by property values being deprecated.Vigilant#registerListenerfunctions were updated to use thePropertyCollector#getPropertyfunction to findPropertyDatainstances. As a result,Vigilant#registerListenerfunctions can now find more properties (instead of only Java field backed ones) and that code is cleaner.All feedback is welcome. In the comments, I'll have a few things I especially want feedback on.