Open
Conversation
nettle
requested changes
Feb 6, 2026
Collaborator
nettle
left a comment
nettle
left a comment
There was a problem hiding this comment.
Quite interesting, but has some issues.
I will definitely try to play with it
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| pip install nox pytest |
Collaborator
There was a problem hiding this comment.
The main point of micromamba is to provide a way to install all dependencies.
If we need to install nox and pytest before micromamba then why do we need micromamba?
Comment on lines
+41
to
+48
| # Bazel 7 provided by micromamba is compiled using a newer java version | ||
| # than the default in Github runner | ||
| - name: Set up JRE 21 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '21' | ||
| distribution: 'temurin' | ||
| java-package: 'jre' |
Collaborator
There was a problem hiding this comment.
That's interesting. I do not see that in Jenkins. Should this be fixed in micromamba env?
|
|
||
| - name: Install micromamba and run tests | ||
| run: | | ||
| source .ci/nox/install.sh |
Collaborator
There was a problem hiding this comment.
Here we basically install micromamba, not nox
| @@ -0,0 +1,73 @@ | |||
| """ | |||
Collaborator
There was a problem hiding this comment.
Can this file be located in .ci/nox/?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want a stable testing framework that supports testing with different Bazel, Python, and Codechecker versions
What:
Notes:
Addresses:
#163