Skip to content

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Feb 2, 2026

Why:
I want to be able to get enough information without having to scroll through pages of logs.
By default, pytest hides the current logs. I need to pass --log-cli-level=DEBUG to each run, to see them.

What:

  • Add stderr as message for process asserts

Addresses:
none

@furtib furtib requested a review from Szelethus February 2, 2026 07:11
@furtib furtib self-assigned this Feb 2, 2026
@furtib furtib added non-functional change ☮️ The patch doesn't change any functionality, e.g. refactoring, documentation, test-only. test ☑️ Adding or refactoring tests labels Feb 2, 2026
@furtib furtib mentioned this pull request Feb 2, 2026
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the point, I'm just wondering if this is the way to do it -- will we always remember to add stderr as a third parameter? Can we just unconditionally print stderr from run_command()? Pytest actually handles output capturing rather elegantly. Though I'm not sure how much it'd litter the output for @nettle who IIRC doesn't use pytest (or not in every environment he tests in).

Still, the change as it stands is an improvement, once we put the effort into it, I suppose there is no reason not to accept it.

@furtib
Copy link
Contributor Author

furtib commented Feb 3, 2026

The idea behind #176 is to show the test author that they need to pass stderr as a 3rd parameter.
It doesn't feel like the best solution, but I have no better idea on how to improve it.

@furtib furtib merged commit eb8ad85 into Ericsson:main Feb 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-functional change ☮️ The patch doesn't change any functionality, e.g. refactoring, documentation, test-only. test ☑️ Adding or refactoring tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants