C# static analyzer refactoring#856
C# static analyzer refactoring#856matecsad wants to merge 2 commits intoEricsson:feature/csharp_pluginfrom
Conversation
matecsad
added
Plugin: C#
|
|
||
| namespace CSharpParser | ||
| { | ||
| class AstVisitorHelper |
There was a problem hiding this comment.
This should be a static class with static helper methods.
|
|
||
| namespace CSharpParser | ||
| { | ||
| class ProgramHelper |
There was a problem hiding this comment.
This should be a static helper class with static methods.
| return allFiles; | ||
| } | ||
|
|
||
| public static string transformConnectionString(string _connectionString) |
There was a problem hiding this comment.
PascalCase naming convention not enforced here.
| using cc.service.csharp; | ||
| using CSharpParser.model; | ||
|
|
||
| class QueryHelper |
There was a problem hiding this comment.
Class has no state, should be a static helper class.
|
|
||
| class QueryHelper | ||
| { | ||
| public AstNodeInfo createAstNodeInfo(CsharpAstNode node) |
There was a problem hiding this comment.
Method names should be in PascalCase.
| return ret; | ||
| } | ||
|
|
||
| public List<AstNodeInfo> createAstNodeInfoList(List<CsharpAstNode> nodeList) |
There was a problem hiding this comment.
Method names should be in PascalCase.
| return ret; | ||
| } | ||
|
|
||
| public FileRange getFileRange(CsharpAstNode node) |
There was a problem hiding this comment.
Method names should be in PascalCase.
| build/ | ||
| build_*/ | ||
| Build/ | ||
| Build_*/ |
There was a problem hiding this comment.
| build/ | |
| build_*/ | |
| Build/ | |
| Build_*/ | |
| [bB]uild/ | |
| [bB]uild_*/ |
This can be simplified.
| EndProject | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "parser", "parser", "{BC34E35A-B109-A120-90EC-15530B70B9CB}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DbModel", "db_model\DbModel.csproj", "{BADE2559-4F0F-21F6-067B-8EDF7DE9DFC1}" |
There was a problem hiding this comment.
Does exist in the project.
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.5.2.0 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "db_model", "db_model", "{2E2F0E00-502D-A052-0019-82CFB9270E3D}" |
There was a problem hiding this comment.
Does exist in the project.
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "csharpservice", "service\src_csharp\csharpservice.csproj", "{1AF03105-21A5-3508-A40F-365ADA9DFF92}" | ||
| EndProject | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src_csharp", "src_csharp", "{37C60329-C8F7-3ACB-DE03-F714C9EE58C5}" |
There was a problem hiding this comment.
Does exist in the project, as the src_csharp folder is per parser / service.
There was a problem hiding this comment.
This solution file looks invalid. Maybe just remove it, as the project files contain enough structure for now.
2 participants
Fixes the pending issues in #584.