Remove -b flag for C# parser#846
Open
LakatosMark1 wants to merge 2 commits intoEricsson:feature/csharp_pluginfrom
Open
Remove -b flag for C# parser#846LakatosMark1 wants to merge 2 commits intoEricsson:feature/csharp_pluginfrom
LakatosMark1 wants to merge 2 commits intoEricsson:feature/csharp_pluginfrom
Conversation
…roj and populate build graph
mcserep
added
Plugin: C#
mcserep
requested changes
Apr 21, 2026
| void addSource(const std::string& filepath_, bool error_); | ||
| const std::vector<std::string>& path_ //, | ||
| ); //const std::string& buildPath_ | ||
| //void addSource(const std::string& filepath_, bool error_); |
Collaborator
There was a problem hiding this comment.
Remove commented out code from codebase.
| bool CsharpParser::parseProjectBuildPath( | ||
| const std::vector<std::string>& paths_, | ||
| const std::string& buildPath_) | ||
| const std::vector<std::string>& paths_ //, |
Collaborator
There was a problem hiding this comment.
Remove commented out comma.
Collaborator
There was a problem hiding this comment.
@LakatosMark1 This is still a pending formatting issue.
Collaborator
Author
|
I have made the canges requested! |
mcserep
requested changes
May 5, 2026
Collaborator
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
Looks almost ready now, some final touches and questions remain.
| { | ||
| if (line[0] == '+' || line[0] == '-') | ||
| // Skip empty lines or non-JSON lines (like debug info "ParallelRun ...") | ||
| if (line.empty() || line[0] != '{') continue; |
Collaborator
There was a problem hiding this comment.
I don't really get this, in a valid JSON file / content, not every line starts with a { char neccesearily.
| visitor.Visit(tree.GetCompilationUnitRoot()); | ||
|
|
||
| // Find the DLL name and append a | to the filename. | ||
| string target = fileToTargetDll.ContainsKey(tree.FilePath) ? fileToTargetDll[tree.FilePath] : "Unknown.dll"; |
Collaborator
There was a problem hiding this comment.
As discussed on previous meeting, we shall not use a fake "Unknown.dll" filename. That could be a valid file. Use null or maybe empty string as extremal value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor C# parser to extract target DLLs from .csproj and populate build graph
Resolves #820