-
Notifications
You must be signed in to change notification settings - Fork 2
UVBeam overhaul #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bhazelton
wants to merge
21
commits into
main
Choose a base branch
from
uvbeam_overhaul
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
UVBeam overhaul #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d49f36 to
7602cb7
Compare
7602cb7 to
d7924d7
Compare
specifically, resulted in a gridding kernel that did not contain the actual beam
d7924d7 to
b6b1f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UVBeam overhaul
Completely overhaul the handling of UVBeam beams.
Note that using this requires having the
fhd_beam_decomposebranch on pyuvdata installed.Note that this currently branches off of #71, so it contains those fixes as well.
fixes #64
Types of Changes
Changelog
Breaking Changes!
New Features
Bug Fixes
Test Changes
Dependency Changes
Version Changes
Build/CI changes
Translation Changes
Checklist
General PR Checklist
New Features Checklist
Existing Tests Checklist
Breaking Changes Checklist
Bug Fixes Checklist
Documentation Checklist
Version Checklist
Build/CI
Translation Checklist