Fixes

Author: PDowney

.github/scripts/check-wordpress-tested-up-to.py

@@ -3,17 +3,15 @@
 
 from __future__ import annotations
 
-import http.client
 import json
 import os
 import re
 import sys
 from pathlib import Path
 
 
-WORDPRESS_API_HOST = "api.wordpress.org"
-WORDPRESS_VERSION_CHECK_PATH = "/core/version-check/1.7/"
 WORDPRESS_LATEST_VERSION = os.environ.get("WORDPRESS_LATEST_VERSION")
+WORDPRESS_VERSION_CHECK_FILE = Path("wordpress-version-check.json")
 SCAN_EXTENSIONS = {".php", ".md", ".txt"}
 DEFAULT_EXCLUDED_DIRS = {
     ".git",
@@ -83,37 +81,24 @@ def get_latest_wordpress_major_minor() -> str:
     if WORDPRESS_LATEST_VERSION:
         return normalize_major_minor(WORDPRESS_LATEST_VERSION)
 
-    connection = http.client.HTTPSConnection(WORDPRESS_API_HOST, timeout=20)
-    connection.request(
-        "GET",
-        WORDPRESS_VERSION_CHECK_PATH,
-        headers={
-            "Accept": "application/json",
-            "User-Agent": "wordpress-tested-up-to-check/1.0",
-        },
-    )
-
-    response = connection.getresponse()
-    try:
-        if response.status != http.client.OK:
-            raise RuntimeError(
-                f"WordPress version-check API returned HTTP {response.status}."
-            )
-
-        payload = json.loads(response.read().decode("utf-8"))
-    finally:
-        connection.close()
+    if not WORDPRESS_VERSION_CHECK_FILE.is_file():
+        raise RuntimeError(
+            "WORDPRESS_LATEST_VERSION must be set, or wordpress-version-check.json must exist."
+        )
 
+    payload = json.loads(WORDPRESS_VERSION_CHECK_FILE.read_text(encoding="utf-8"))
     versions = []
+
     for offer in payload.get("offers", []):
         version = offer.get("current") or offer.get("version")
         if isinstance(version, str) and VERSION_PATTERN.match(version):
             versions.append(version)
 
     if not versions:
-        raise RuntimeError("Could not determine the latest WordPress version from the version-check API.")
+        raise RuntimeError("Could not determine the latest WordPress version.")
 
-    return normalize_major_minor(max(versions, key=version_sort_key))
+    latest = max(versions, key=version_sort_key)
+    return normalize_major_minor(latest)
 
 
 def normalize_major_minor(version: str) -> str:

.github/workflows/wordpress-tested-up-to.yml

@@ -24,5 +24,12 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v6
 
+      - name: Download WordPress version data
+        run: |
+          curl --fail --silent --show-error --location \
+            --proto '=https' --tlsv1.2 \
+            https://api.wordpress.org/core/version-check/1.7/ \
+            --output wordpress-version-check.json
+
       - name: Check WordPress Tested Up To metadata
         run: python3 .github/scripts/check-wordpress-tested-up-to.py

tests/unit/DomainValidationTest.php

@@ -41,6 +41,17 @@ private function resetTestState(): void {
 		$wp_settings_errors = array();
 	}
 
+	/**
+	 * Get registered settings errors from the WordPress test state.
+	 *
+	 * @return array<int, array<string, string>> Registered settings errors.
+	 */
+	private function get_settings_errors(): array {
+		global $wp_settings_errors;
+
+		return is_array( $wp_settings_errors ) ? $wp_settings_errors : array();
+	}
+
 	/**
 	 * Clean HTTPS domains are accepted and normalized.
 	 *
@@ -173,7 +184,7 @@ public function test_domain_list_keeps_unique_clean_https_domains(): void {
 				'message' => 'Some preconnect domains were rejected for security reasons: https://example.com/path (file paths are not allowed; use domains only)',
 				'type'    => 'warning',
 			),
-			$GLOBALS['wp_settings_errors']
+			$this->get_settings_errors()
 		);
 	}