Fixes

Author: PDowney

.github/scripts/__pycache__/check-wordpress-tested-up-to.cpython-314.pyc

@@ -3,19 +3,16 @@
 
 from __future__ import annotations
 
+import http.client
 import json
 import os
 import re
-import subprocess
 import sys
-import urllib.request
 from pathlib import Path
 
 
-WORDPRESS_VERSION_CHECK_URL = os.environ.get(
-    "WORDPRESS_VERSION_CHECK_URL",
-    "https://api.wordpress.org/core/version-check/1.7/",
-)
+WORDPRESS_API_HOST = "api.wordpress.org"
+WORDPRESS_VERSION_CHECK_PATH = "/core/version-check/1.7/"
 WORDPRESS_LATEST_VERSION = os.environ.get("WORDPRESS_LATEST_VERSION")
 SCAN_EXTENSIONS = {".php", ".md", ".txt"}
 DEFAULT_EXCLUDED_DIRS = {
@@ -25,6 +22,7 @@
     "dist",
     "node_modules",
     "plugin-check-build",
+    "__pycache__",
     "vendor",
 }
 TESTED_UP_TO_PATTERN = re.compile(
@@ -41,7 +39,7 @@ def main() -> int:
     findings = find_tested_up_to_entries(excluded_dirs)
 
     if not findings:
-        message = "No Tested up to metadata was found in tracked PHP, Markdown, or text files."
+        message = "No Tested up to metadata was found in PHP, Markdown, or text files."
         print_github_error(message)
         write_summary(latest_version, [], [message])
         return 1
@@ -85,13 +83,26 @@ def get_latest_wordpress_major_minor() -> str:
     if WORDPRESS_LATEST_VERSION:
         return normalize_major_minor(WORDPRESS_LATEST_VERSION)
 
-    request = urllib.request.Request(
-        WORDPRESS_VERSION_CHECK_URL,
-        headers={"User-Agent": "wordpress-tested-up-to-check/1.0"},
+    connection = http.client.HTTPSConnection(WORDPRESS_API_HOST, timeout=20)
+    connection.request(
+        "GET",
+        WORDPRESS_VERSION_CHECK_PATH,
+        headers={
+            "Accept": "application/json",
+            "User-Agent": "wordpress-tested-up-to-check/1.0",
+        },
     )
 
-    with urllib.request.urlopen(request, timeout=20) as response:
-        payload = json.load(response)
+    response = connection.getresponse()
+    try:
+        if response.status != http.client.OK:
+            raise RuntimeError(
+                f"WordPress version-check API returned HTTP {response.status}."
+            )
+
+        payload = json.loads(response.read().decode("utf-8"))
+    finally:
+        connection.close()
 
     versions = []
     for offer in payload.get("offers", []):
@@ -130,7 +141,7 @@ def find_tested_up_to_entries(
 ) -> list[dict[str, str | int | None]]:
     findings = []
 
-    for path in get_tracked_files():
+    for path in get_scanned_files(excluded_dirs):
         if not should_scan(path, excluded_dirs):
             continue
 
@@ -152,16 +163,24 @@ def find_tested_up_to_entries(
     return findings
 
 
-def get_tracked_files() -> list[Path]:
-    result = subprocess.run(
-        ["git", "ls-files", "*.php", "*.md", "*.txt"],
-        check=True,
-        stdout=subprocess.PIPE,
-        stderr=subprocess.PIPE,
-        text=True,
-    )
+def get_scanned_files(excluded_dirs: set[str]) -> list[Path]:
+    root = Path.cwd()
+    paths = []
+
+    for current_dir, dirnames, filenames in os.walk(root):
+        dirnames[:] = [
+            dirname for dirname in dirnames if dirname not in excluded_dirs
+        ]
+
+        current_path = Path(current_dir)
+        for filename in filenames:
+            path = current_path / filename
+            relative_path = path.relative_to(root)
+
+            if should_scan(relative_path, excluded_dirs):
+                paths.append(relative_path)
 
-    return [Path(line) for line in result.stdout.splitlines() if line.strip()]
+    return sorted(paths)
 
 
 def should_scan(path: Path, excluded_dirs: set[str]) -> bool:

.github/scripts/check-wordpress-tested-up-to.py

@@ -5,12 +5,8 @@
 name: WordPress Tested Up To
 
 on:
-  push:
-    branches: [ main ]
-  pull_request:
   schedule:
     - cron: '23 12 * * *'
-  workflow_dispatch:
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}

.github/workflows/wordpress-tested-up-to.yml

@@ -14,3 +14,7 @@
 /.phpcs-cache
 /.phpstan.cache/
 /.psalm/cache/
+
+# Python tooling caches
+__pycache__/
+*.py[cod]

.gitignore

@@ -192,7 +192,7 @@ public function test_resource_hints_use_wordpress_filter_contract(): void {
 
 		$preconnect_hints  = es_optimizer_add_preconnect_resource_hints( array(), 'preconnect' );
 		$dns_prefetch_urls = es_optimizer_add_dns_prefetch_resource_hints( array(), 'dns-prefetch' );
-		$cdn_hint          = $this->findResourceHintByHref( $preconnect_hints, 'https://cdn.example.com' );
+		$cdn_hint          = $this->find_resource_hint_by_href( $preconnect_hints, 'https://cdn.example.com' );
 
 		$this->assertContains( array( 'href' => 'https://fonts.gstatic.com', 'crossorigin' => 'anonymous' ), $preconnect_hints );
 		$this->assertIsArray( $cdn_hint );
@@ -235,7 +235,7 @@ public function test_resource_hints_are_not_added_when_feature_flags_are_disable
 	 * @param string                                  $href  Hint href to locate.
 	 * @return array<string, mixed>|null Matching hint, if present.
 	 */
-	private function findResourceHintByHref( array $hints, string $href ): ?array {
+	private function find_resource_hint_by_href( array $hints, string $href ): ?array {
 		foreach ( $hints as $hint ) {
 			if ( is_array( $hint ) && $href === ( $hint['href'] ?? null ) ) {
 				return $hint;