Add renderer mixin #146
Add renderer mixin #146
Conversation
me4502
left a comment
me4502
left a comment
There was a problem hiding this comment.
In general there are a few odd changes that would need to be fixed up for progress this PR- otherwise a lot of it looks like what I have locally. I'd opted to not add a mixin here, to prevent compatibility issues in a released copy of the mod. For dev builds etc it feels like it'd be fine to do this, and then have the mixins removed once Fabric update the rendering API.
| "key.worldeditcui.clear": "WorldEdit Auswahl aufheben", | ||
| "key.worldeditcui.chunk": "Chunkgrenzen An/Aus", | ||
| "key.categories.worldeditcui": "WorldEditCUI", | ||
| "key.category.worldeditcui.general": "WorldEditCUI", |
There was a problem hiding this comment.
Are these changes to the keybind category name key here necessary?
There was a problem hiding this comment.
Yes, it was a necessary change because Keybind.Category now requires a ResourceLocation to register, which requires a namespace and path... unless you would like to implement a mixin to get around that.
|
I've also just pushed my initial 1.21.10 work I did a while ago, would you be able to please rebase onto the mc/1.21.10 branch, and re-target this PR there? |
worldeditcui-fabric/src/main/java/org/enginehub/worldeditcui/callback/WorldRenderCallback.java
Outdated
Show resolved
Hide resolved
worldeditcui-fabric/src/main/java/org/enginehub/worldeditcui/render/WecuiRenderContext.java
Outdated
Show resolved
Hide resolved
worldeditcui-fabric/src/main/resources/worldeditcui.mixins.json
Outdated
Show resolved
Hide resolved
worldeditcui-fabric/src/main/java/org/enginehub/worldeditcui/callback/WorldRenderCallback.java
Show resolved
Hide resolved
|
Sorry for the delayed responge, GitHub didn't send notifications for those pushes or trigger any webhooks :/ It looks like Fabric have now merged this into their API- would it be possible to please update to just use the API rather than the mixin additions? Also maybe please reply to this message to see if that makes sure GitHub sends notifications 😓 |
|
I have a working GPU now, so can take a look at making those changes- I'll merge this into my branch and work from there. Thanks :) |
* Minor changes * Add render mixin * Updated keybinds to new namespace standard * Added refmap for loom * Fixed unnecessary warnings * Implement START callback for consistency * Removed 7.3.12 from breaking * Formatting and javadoc comments
2 participants
Fabric removed their old rendering system and will implement a new one in the future, I'm sure. In the meantime I don't want to play without this mod so I took the liberty of reimplementing rendering as callbacks.