call ConfigurationLoadEvent after the configuration is loaded on start #2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me4502
approved these changes
Jan 23, 2026
Member
me4502
left a comment
me4502
left a comment
There was a problem hiding this comment.
I'm happy with this as-is. Realistically we need to redo the startup lifecycle in WE8 as it doesn't currently match MC super well, but doing it this way at least is tying configuration load directly to the config.load call, which is better than what we had before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2895
the cause of the problem is that ConfigurationLoadEvent is called before the config is actually loaded, i have added debug logging to visualize this: https://cpaste.de/figewenuhe.sql - the paths from the config were never set in the SchematicsManager (and also in the SessionManager).