Implement convex selection enhancements and error handling for duplicate vertices and limits. (Resolve #2817)#2849
Open
ssquadteam wants to merge 3 commits intoEngineHub:version/7.3.xfrom
Open
Conversation
…ate vertices and limits. (Resolve EngineHub#2817)
…ceWand for improved readability and consistency
…t assertions in ConvexPolyhedralRegionSpecTest
Member
|
Before I review any of the code, could you explain what situations this is improving and how the behavior differs? Additionally, please don't claim this resolves #2817 when it obviously does not add a formal specification of what the behavior should be, or even an informal one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.