Conversation
3f1652b to
deb26cb
Compare
|
@avaruus1 if you're interested in keeping the Sponge part up-to-date with everything, there are changes here that need to be made. As we don't want to maintain it, I just removed the broken code. This won't land for at least a couple months so there's plenty of time to adjust. |
I think the side effect calculation is fine to remove as is. The block change flags are set already here. Is there some other scenarios where this is possibly used? |
|
No, it's only useful if the platform calls out to it. If you don't want to port the chunk section stuff then there should be nothing to do. |
094750c to
00a4050
Compare
00a4050 to
6648b87
Compare
|
I have tested this as much as I could, but it's still possible some edge case isn't being handled. Otherwise, this should be good to merge. |
worldedit-core/src/main/java/com/sk89q/worldedit/internal/util/collection/ChunkSectionMask.java
Outdated
Show resolved
Hide resolved
|
Is this dead? |
|
Not really, but I haven't had energy to work on it. |
|
can we label this as type:bug since it's the fix for #2516 ? 2516 renders the mod unusable for redstone, and I feel like the labels here should reflect that |
|
I'm not sure how adding that or not changes anything. It's not like we're going to merge it in to a patch version because it's now a "bug fix", it's way too drastic of a change for that. |
Fixes #2516
TODO: