Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
============================================
- Coverage 11.44% 11.43% -0.02%
Complexity 1002 1002
============================================
Files 805 805
Lines 32598 32646 +48
Branches 3783 3800 +17
============================================
Hits 3732 3732
- Misses 28688 28736 +48
Partials 178 178
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So few problems atm:
Definitely open to suggestions
This was done as it's the most flexible way of handling NBT data and is also usable in CraftBook (and maybe WG if blacklist is extended for item nbt or whatever)