Skip to content

feat!: use node version 24#720

Open
CodeReaper wants to merge 2 commits intoEndBug:mainfrom
CodeReaper:upgrade-node-24
Open

feat!: use node version 24#720
CodeReaper wants to merge 2 commits intoEndBug:mainfrom
CodeReaper:upgrade-node-24

Conversation

@CodeReaper
Copy link

@CodeReaper CodeReaper commented Mar 14, 2026

Resolves #719.

Summary by CodeRabbit

  • Chores
    • Raised the minimum Node.js requirement to v24 to align runtimes.
    • Updated Node type definitions to match the newer Node version.
    • Updated CI/action runtime to use Node.js 24 for consistency across builds and tooling.

@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3124dae7-1315-4249-9349-b3671543012e

📥 Commits

Reviewing files that changed from the base of the PR and between e555937 and 12d5de4.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • action.yml
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • action.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

📝 Walkthrough

Walkthrough

Updates Node.js target from 20 to 24: package.json bumps engines.node and @types/node; action.yml updates the GitHub Action runtime to Node.js 24. No changes to exported or public API declarations.

Changes

Cohort / File(s) Summary
Package manifest
package.json
Bumped engines.node from >=20 to >=24; updated devDependency @types/node from 20.8.2 to 24.12.0.
Action runtime
action.yml
Changed action runtime from node20 to node24 (runs.using updated).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hopped from v20 to v24,
New types in paw and runner at the door.
CI wakes brighter, no warnings to chew,
A carrot-coded update — fresh and true! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: upgrading the action to use Node.js version 24, which directly addresses the deprecation warning mentioned in the linked issue.
Linked Issues check ✅ Passed The pull request successfully addresses issue #719 by updating the Node.js runtime from version 20 to 24 and bumping the minimum engine requirement, eliminating the deprecation warning.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the Node.js 24 upgrade objective: updating action.yml runtime version and package.json dependencies and engine requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 39: The project updated package.json engines to "node": ">=24" but
action.yml still declares the GitHub Actions runtime as node20; open action.yml
and change the runs.using value from "node20" to "node24" (and ensure any
related mentions of Node 20 in that file are updated consistently), keeping the
action.yml metadata aligned with package.json to eliminate the Node 20
deprecation warning.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5649a0e9-84de-4416-8908-babd95f29629

📥 Commits

Reviewing files that changed from the base of the PR and between 1539a6a and 89a0eb7.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected

1 participant