Add uniqueName property and update attachment naming in SnapshotTest#234
Open
Add uniqueName property and update attachment naming in SnapshotTest#234
uniqueName property and update attachment naming in SnapshotTest#234Conversation
noahsmartin
reviewed
Apr 28, 2025
| case .previewProvider(let internalPreview, let previewType): | ||
| return Preview(preview: internalPreview, type: previewType, uniqueName: uniqueName) | ||
| case .previewRegistry(let anyValue): | ||
| #if compiler(>=5.9) |
Member
There was a problem hiding this comment.
Can we get rid of these now that Xcode 16 is out?
noahsmartin
reviewed
Apr 28, 2025
|
|
||
| private enum InternalPreview { | ||
| case previewProvider(_Preview, any SwiftUI.PreviewProvider.Type) | ||
| // Can't use DeveloperToolsSupport.Preview here because it's not available before iOS 17 |
Member
There was a problem hiding this comment.
Can you use a protocol that you conform DeveloperToolsSupport.Preview to in an extension?
noahsmartin
reviewed
Apr 28, 2025
| public let platform: PreviewPlatform? | ||
| } | ||
|
|
||
| private struct PreviewTypeInfo { |
Member
There was a problem hiding this comment.
Having a PreviewType and also PreviewTypeInfo is a bit confusing, can we clean this up?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.