Skip to content

Issue35 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Emerassi merged 2 commits into from
May 15, 2025
Merged

Issue35 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32516d7
Working on fixing starting job rando bugs
Emerassi May 15, 2025
36f5f6c
Fixed starting job rando giving every player the same jobs.
Emerassi May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions worlds/crystal_project/Items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
from typing import Dict, Set, Tuple, NamedTuple, Optional, List
from BaseClasses import ItemClassification

import random

class ItemData(NamedTuple):
category: str
code: Optional[int]
Expand Down Expand Up @@ -1520,5 +1518,5 @@ def get_item_names_per_category() -> Dict[str, Set[str]]:

return categories

def get_random_starting_jobs() -> List[Job]:
return random.sample(job_list, 6)
def get_random_starting_jobs(self, count:int) -> List[Job]:
return self.random.sample(job_list, count)
4 changes: 3 additions & 1 deletion worlds/crystal_project/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,14 @@ class CrystalProjectWorld(World):
boss_name_to_id = {boss.name: boss.code for boss in get_bosses(-1, None)}
location_name_to_id.update(boss_name_to_id)
item_name_groups = get_item_names_per_category()
startingJobs = get_random_starting_jobs()
startingJobs = []
web = CrystalProjectWeb()

logger = logging.getLogger()

def generate_early(self):
self.startingJobs = get_random_starting_jobs(self, 6)

self.multiworld.push_precollected(self.create_item("Item - Home Point Stone"))

if self.options.randomizeStartingJobs:
Expand Down
Loading