Fix memory leak in CreateTexture and bump version to 1.2.0 #72
Conversation
- Implemented RAII for `UPackage` using `TStrongObjectPtr`. - Added `CleanupOnEarlyExit` lambda to clear flags (`RF_Standalone`, `RF_MarkAsRootSet`) and mark package as garbage on cancellation. - Inserted cancellation checks immediately after `EnterProgressFrame` calls to ensure responsiveness and cleanup. - Bumped plugin version to 1.2.0 in `.uplugin`. - Updated `CHANGELOG.md` and `CHANGELOG.ja.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses a memory leak issue where
UPackageobjects were not properly cleaned up if the texture generation process was cancelled or failed (specifically during package creation).Key changes:
UPackage*withTStrongObjectPtr<UPackage>to better manage the object lifecycle.RF_StandaloneandRF_MarkAsRootSetflags and callMarkAsGarbage()if the operation is cancelled before the package is marked dirty (saved).ShouldCancel()checks to occur immediately afterEnterProgressFrame()to catch cancellation events as early as possible.Note on Error Handling: The existing logic for texture processing errors (e.g., unsupported format) intentionally continues execution to produce a result (even if partial/black), preserving the user's workflow. Therefore, explicit package destruction is not applied in those loops to maintain existing behavior.
PR created automatically by Jules for task 1289736565483385526 started by @EmbarrassingMoment