Skip to content

Fix symfony 42 deprecation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ppm1337 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix symfony 42 deprecation #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bf6159
fix(unicode): use mb_strtolower
Jun 8, 2020
7397800
Merge pull request #1 from jangaehler/utf-8-fixes
enloc-port Jun 9, 2020
0fddb08
Resolve deprecation: A tree builder without a root node is deprecated…
Jun 14, 2020
88c08c9
fix indentation of composer.json
ppm1337 Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DataGrid/QueryHandler/DoctrineQueryHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public function transformValueCase(string $value): string
if ($this->queryConfig->isCaseSensitive()) {
return $value;
} else {
return strtolower($value);
return mb_strtolower($value, 'UTF-8');
}
}

Expand Down
3 changes: 1 addition & 2 deletions DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ class Configuration implements ConfigurationInterface
*/
public function getConfigTreeBuilder()
{
$treeBuilder = new TreeBuilder();
$rootNode = $treeBuilder->root('bilendi_dev_express');
$treeBuilder = new TreeBuilder('bilendi_dev_express');
Copy link
Collaborator

@mgiraud mgiraud Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way of using the first argument of constructor as the root node is a 4.X feature an thus not complient with SF2.X or 3.X, please can you use the same trick as they do in the fosuserbundle : https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/DependencyInjection/Configuration.php#L36
(and sorry for the delay)


// Here you should define the parameters that are allowed to
// configure your bundle. See the documentation linked above for
Expand Down
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"php": "^7.0",
"doctrine/orm": "^2.5",
"lstrojny/functional-php": "^1.4",
"symfony/framework-bundle": "^2.6|^3.2|^4.4"
"symfony/framework-bundle": "^2.6|^3.2|^4.4",
"ext-mbstring": "*"
},
"require-dev": {
"phpunit/phpunit": "^5.7",
Expand Down